Move important modules to top-level #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alihamdan
commented
Dec 31, 2024
| env: | ||
| CI: true | ||
| UV_SYSTEM_PYTHON: 1 | ||
| COVERAGE_CORE: sysmon |
Member
Author
There was a problem hiding this comment.
Tested locally on Python 3.13 (this works on 3.12+). The time of execution of:
pytest: ~5 secondspytest --covwithout this change: ~13 secondspytest --covwith this change: ~5 seconds
Basically, this removes the overhead of coverage. It requires setting branch = false in [tool.coverage.run].
benoit9126
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-organizes the
utilssubpackage. The important modules are moved to top-level while internal modules are kept inutils.This is to separate modules that are meant for user use from modules that are meant for internal use. This way we are able to exclude the internal modules from the documentation and make using the important modules easier at the same time.
Old modules are deprecated and will be removed in a future version.