Support star and zigzag transformers with non brought out neutrals #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit9126
approved these changes
Jan 6, 2025
Saelyos
reviewed
Jan 6, 2025
Comment on lines
262
to
264
| f"Transformer {id!r} with vector group {parameters.vg} does not have have a " | ||
| f"brought out neutral on the LV side. The neutral phase 'n' is ignored. If " | ||
| f"you meant to use a brought out neutral, use vector group '{correct_vg}'. " |
| clock = parameters.phase_displacement | ||
|
|
||
| w1_has_neutral = w1.endswith("N") | ||
| if phases1 is None: |
Collaborator
There was a problem hiding this comment.
Should we emit a warning if n is in bus1.phases but w1_has_neutral is False ?
Member
Author
There was a problem hiding this comment.
No it is a valid use case. For example, imagine two transformers on the same bus (in the same substation) where one has a brought out neutral and the other doesn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #308