Skip to content

Five9 updates for handling state updates on call completion & TimeView render interval#1586

Merged
paulfalgout merged 2 commits intodevelopfrom
five9-updates
Jan 21, 2026
Merged

Five9 updates for handling state updates on call completion & TimeView render interval#1586
paulfalgout merged 2 commits intodevelopfrom
five9-updates

Conversation

@nmajor25
Copy link
Contributor

@nmajor25 nmajor25 commented Jan 20, 2026

Shortcut Story ID: [sc-65412]

These changes were confirmed to work in Upperline Sandbox.

Summary by CodeRabbit

  • Bug Fixes
    • Timer display now updates every second for improved real-time accuracy, previously refreshed every minute, providing enhanced responsiveness during call operations.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

📝 Walkthrough

Walkthrough

State updates in Five9 call lifecycle methods (callEnded, callFinished) are batched into single setState calls instead of multiple separate calls. Additionally, the timer view render frequency is increased from 60 seconds to 1 second for more responsive display updates.

Changes

Cohort / File(s) Summary
State update batching
packages/care-ops-five9/five9_app.js
Consolidated multiple setState calls into single object-based updates in callEnded (combining isTransferredCall and callTime) and callFinished (combining isCalling, actionId, callTime, isTransferredCall). No logic changes; control flow remains unchanged.
Timer render frequency
packages/care-ops-five9/five9_views.js
Changed TimerView.onRender delay from 60000 ms to 1000 ms, increasing render frequency from once per 60 seconds to once per second for real-time timer updates.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • paulfalgout

Poem

🐰 Hop-hop, the states now batch with glee,
No more setState calls, so wild and free!
One second ticks the timer true,
Consolidated logic—faster too!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the two main changes: batching state updates on call completion in Five9 app and adjusting the TimerView render interval from 60 seconds to 1 second.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Five9 integration to improve call state management and timer display accuracy. The changes ensure proper cleanup of call-related state when calls end and increase the timer update frequency for better real-time feedback.

Changes:

  • Increased timer render interval from 60 seconds to 1 second for more accurate call duration display
  • Consolidated multiple setState calls into single object updates in call event handlers
  • Added explicit cleanup of callTime and isTransferredCall state in the callFinished handler

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/care-ops-five9/five9_views.js Reduced timer re-render interval from 60 seconds to 1 second for real-time display
packages/care-ops-five9/five9_app.js Refactored state updates to use object syntax and added comprehensive state cleanup in callFinished

@paulfalgout paulfalgout merged commit 0fee527 into develop Jan 21, 2026
6 checks passed
@paulfalgout paulfalgout deleted the five9-updates branch January 21, 2026 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants