Improve RECEIVE_LN_ADDRESS warning #286
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9qeklajc
reviewed
Jan 5, 2026
| available_balance = proofs_balance - user_balance | ||
| min_amount = 210 if unit == "sat" else 210000 | ||
| if available_balance > min_amount: | ||
| if not settings.receive_ln_address: |
Contributor
There was a problem hiding this comment.
better outside the loop to not spam the logger, when multiple minsts are set
Contributor
Author
|
actually i think before was good enough |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the
RECEIVE_LN_ADDRESScheck inside the payout loop so it doesn't stop the loop if not set initially, but warns when attempting payout.