chore(repo): remove dead code and repository noise#294
Merged
RtlZeroMemory merged 1 commit intomainfrom Mar 18, 2026
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
📝 WalkthroughWalkthroughThis PR performs cleanup across multiple packages: removes aggregation constraints and overflow culling modules, updates profiling infrastructure documentation, eliminates temporary benchmarking utilities, and corrects relative import paths in test files. Changes
Possibly related PRs
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
packages/core/src/constraints/aggregation.ts: repo-wide search found no imports or re-exports;npx --yes --package knip knip --reporter compactreported it as an unused file; sibling aggregation behavior remains implemented directly inpackages/core/src/constraints/resolver.tsand is still covered by the existing constraint tests.packages/core/src/renderer/renderToDrawlist/overflowCulling.ts: repo-wide search found no imports or re-exports; Knip reported it as an unused file; overflow handling used at runtime remains inrenderTree.tsandwidgets/containers.ts.packages/ink-compat/src/_bench_layout_profile.ts: repo-wide search found no imports, exports, or script references; Knip reported it as an unused file; it was shipping in the publishable source tree without any wired benchmark path.packages/core/src/widgets/tests/protocol.test.tstopackages/core/src/widgets/__tests__/protocol.test.ts: the test had no runtime imports, compiled intodist/widgets/tests, and sat outside the package exclusion pattern for__tests__; after the move it builds intodist/widgets/__tests__and is picked up by the normal test discovery path.packages/node/src/worker/testShims/*topackages/node/src/__tests__/worker/testShims/*: repo-wide search showed these shims are referenced only frompackages/node/src/__tests__/worker_integration.test.tsandpackages/node/src/__e2e__/runtime-reduced.e2e.test.ts; path rewrites preserve behavior while moving them under package-excluded test output.packages/core/src/layout/engine/layoutEngine.tsandpackages/core/src/pipeline.tswithout changing the exported__layoutProfilehook.packages/core/src/constraints/aggregation.ts,packages/core/src/renderer/renderToDrawlist/overflowCulling.ts, orpackages/ink-compat/src/_bench_layout_profile.tsas unused files. It still reports the relocated node test shims as unused-file false positives because they are loaded only via test URL strings and dynamic imports.npx depcruise ...resolves to the wrong published package in this environment, so I used the alloweddependency-cruiser/madgefallbacks.npx -y dependency-cruiser --no-config packages/core/src packages/node/src packages/jsx/src --output-type errreported no violations but only cruised 3 modules / 2 dependencies, so I cross-checked withnpx -y madge --circular --extensions ts,tsx,mjs --exclude '(^|/)dist/' --ts-config tsconfig.json packages/core/src packages/node/src packages/jsx/src, which reported 7 pre-existing cycles inpackages/core/src/widgets/types*.tsand no cleanup-induced cycles.Validation
npm run lintnpm run typechecknpm run buildnode scripts/run-tests.mjsnpx --yes --package knip knip --reporter compactnpx -y dependency-cruiser --no-config packages/core/src packages/node/src packages/jsx/src --output-type errnpx -y madge --circular --extensions ts,tsx,mjs --exclude '(^|/)dist/' --ts-config tsconfig.json packages/core/src packages/node/src packages/jsx/srcfind packages/core/dist -path '*/widgets/tests/*' -o -path '*/widgets/__tests__/protocol.test.js' | sortfind packages/node/dist -path '*/worker/testShims/*' -o -path '*/__tests__/worker/testShims/*' | sortfind packages/ink-compat/dist -name '*bench_layout_profile*' | sort