Skip to content

Conversation

rubensworks
Copy link
Collaborator

This WIP PR adds support for the new reifier and triple terms syntax in SPARQL 1.2.

While it is too early to merge this PR, I've started this draft PR just to raise awareness that this is being worked on, to avoid unnecessary duplicated efforts.

Comment on lines +50 to +112
"subject": {
"termType": "BlankNode",
"value": "g_0"
},
"predicate": {
"termType": "Variable",
"value": "p"
},
"object": {
"termType": "Variable",
"value": "o"
}
},
{
"termType": "Quad",
"value": "",
"subject": {
"termType": "NamedNode",
"value": "http://example.com/ns#iri"
},
"predicate": {
"termType": "NamedNode",
"value": "http://www.w3.org/1999/02/22-rdf-syntax-ns#reifies"
},
"object": {
"termType": "Quad",
"value": "",
"subject": {
"termType": "BlankNode",
"value": "g_0"
},
"predicate": {
"termType": "Variable",
"value": "p"
},
"object": {
"termType": "Variable",
"value": "o"
},
"graph": {
"termType": "DefaultGraph",
"value": ""
}
},
"graph": {
"termType": "DefaultGraph",
"value": ""
}
},
{
"subject": {
"termType": "NamedNode",
"value": "http://example.com/ns#iri"
},
"predicate": {
"termType": "NamedNode",
"value": "http://example.com/ns#r"
},
"object": {
"termType": "Variable",
"value": "Z"
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This first reificationBlock (g_0) has 2 triple entries. This is in line with previous test results.
The second block (g1) has only one entry, missing a triple in the form of g_1 rdf:reifies quad .
Is this intended? If so, can you explain why?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had a look at this test, but everything seems correct to me here.
I don't see a g1 in this test.
Are you sure you raised this comment on the right test?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I raised it on the wrong test. This comment should be on the sparql-1-2-annotation-anonreifier-multiple-01, sorry for confusion.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right. The following triple appears to be missing:

        {
          "termType": "Quad",
          "value": "",
          "subject": {
            "termType": "BlankNode",
            "value": "g_1"
          },
          "predicate": {
            "termType": "NamedNode",
            "value": "http://www.w3.org/1999/02/22-rdf-syntax-ns#reifies"
          },
          "object": {
            "termType": "Quad",
            "value": "",
            "subject": {
              "termType": "Variable",
              "value": "s"
            },
            "predicate": {
              "termType": "NamedNode",
              "value": "http://example.com/ns#p"
            },
            "object": {
              "termType": "Variable",
              "value": "o"
            },
            "graph": {
              "termType": "DefaultGraph",
              "value": ""
            }
          },
          "graph": {
            "termType": "DefaultGraph",
            "value": ""
          }
        },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants