-
Notifications
You must be signed in to change notification settings - Fork 68
SPARQL 1.2 support #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
SPARQL 1.2 support #182
Conversation
"subject": { | ||
"termType": "BlankNode", | ||
"value": "g_0" | ||
}, | ||
"predicate": { | ||
"termType": "Variable", | ||
"value": "p" | ||
}, | ||
"object": { | ||
"termType": "Variable", | ||
"value": "o" | ||
} | ||
}, | ||
{ | ||
"termType": "Quad", | ||
"value": "", | ||
"subject": { | ||
"termType": "NamedNode", | ||
"value": "http://example.com/ns#iri" | ||
}, | ||
"predicate": { | ||
"termType": "NamedNode", | ||
"value": "http://www.w3.org/1999/02/22-rdf-syntax-ns#reifies" | ||
}, | ||
"object": { | ||
"termType": "Quad", | ||
"value": "", | ||
"subject": { | ||
"termType": "BlankNode", | ||
"value": "g_0" | ||
}, | ||
"predicate": { | ||
"termType": "Variable", | ||
"value": "p" | ||
}, | ||
"object": { | ||
"termType": "Variable", | ||
"value": "o" | ||
}, | ||
"graph": { | ||
"termType": "DefaultGraph", | ||
"value": "" | ||
} | ||
}, | ||
"graph": { | ||
"termType": "DefaultGraph", | ||
"value": "" | ||
} | ||
}, | ||
{ | ||
"subject": { | ||
"termType": "NamedNode", | ||
"value": "http://example.com/ns#iri" | ||
}, | ||
"predicate": { | ||
"termType": "NamedNode", | ||
"value": "http://example.com/ns#r" | ||
}, | ||
"object": { | ||
"termType": "Variable", | ||
"value": "Z" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This first reificationBlock (g_0
) has 2 triple entries. This is in line with previous test results.
The second block (g1
) has only one entry, missing a triple in the form of g_1 rdf:reifies quad
.
Is this intended? If so, can you explain why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just had a look at this test, but everything seems correct to me here.
I don't see a g1
in this test.
Are you sure you raised this comment on the right test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I raised it on the wrong test. This comment should be on the sparql-1-2-annotation-anonreifier-multiple-01
, sorry for confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're right. The following triple appears to be missing:
{
"termType": "Quad",
"value": "",
"subject": {
"termType": "BlankNode",
"value": "g_1"
},
"predicate": {
"termType": "NamedNode",
"value": "http://www.w3.org/1999/02/22-rdf-syntax-ns#reifies"
},
"object": {
"termType": "Quad",
"value": "",
"subject": {
"termType": "Variable",
"value": "s"
},
"predicate": {
"termType": "NamedNode",
"value": "http://example.com/ns#p"
},
"object": {
"termType": "Variable",
"value": "o"
},
"graph": {
"termType": "DefaultGraph",
"value": ""
}
},
"graph": {
"termType": "DefaultGraph",
"value": ""
}
},
This WIP PR adds support for the new reifier and triple terms syntax in SPARQL 1.2.
While it is too early to merge this PR, I've started this draft PR just to raise awareness that this is being worked on, to avoid unnecessary duplicated efforts.