Skip to content

Removed unneeded comment #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apphp merged 3 commits into from
Aug 14, 2025
Merged

Removed unneeded comment #382

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc48e95
Removed unneeded comment
apphp Aug 6, 2025
6a57850
Removed unneeded comments
apphp Aug 12, 2025
ca0612d
Removed 'Size and Performance' section from docs
apphp Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/NeuralNet/ActivationFunctions/Softsign/Softsign.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ class Softsign implements ActivationFunction, IBufferDerivative
*/
public function activate(NDArray $input) : NDArray
{
// Calculate |x|
Copy link
Member

@andrewdalpino andrewdalpino Aug 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but what about the rest of the comments? I might have not been as clear as I could have in my review, sorry for that, but I meant it to apply to all of these types of comments in this class and any similar class not just the one on this line.

Copy link
Author

@apphp apphp Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, please re-view

$absInput = NumPower::abs($input);

// Calculate 1 + |x|
Expand Down
Loading