Skip to content

Improve strategy for finding dot.exe #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chtenb merged 4 commits into from
Sep 4, 2025
Merged

Improve strategy for finding dot.exe #112

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fbd123c
Improve strategy for finding dot.exe
chtenb Sep 4, 2025
c98d10e
fixup
chtenb Sep 4, 2025
c99ed5b
improve error msg
chtenb Sep 4, 2025
37a0f53
add readonly modifier
chtenb Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 14 additions & 18 deletions Rubjerg.Graphviz/GraphvizCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,19 @@ internal static string Rid
}
}

internal static Lazy<string> _DotExePath = new Lazy<string>(() =>
// If graphviz is not found in the runtimes folder, look in the current directory for compatibility with nonportable windows builds.
new string[] {
Path.Combine(AppContext.BaseDirectory, "runtimes", Rid, "native", "dot"),
Path.Combine(AppContext.BaseDirectory, "runtimes", Rid, "native", "dot.exe"),
"dot",
"dot.exe"
}.FirstOrDefault(File.Exists));
internal static readonly Lazy<string> _DotExePath = new Lazy<string>(() =>
{
// Depending on the method of deployment, there are several possible directories to look for dot
string[] possibleLocations = [
Path.Combine(AppContext.BaseDirectory, "runtimes", Rid, "native"),
Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location),
Path.GetDirectoryName(AppContext.BaseDirectory),
""
];
return possibleLocations.Select(dir => Path.Combine(dir, "dot")).FirstOrDefault(File.Exists)
?? possibleLocations.Select(dir => Path.Combine(dir, "dot.exe")).FirstOrDefault(File.Exists)
?? throw new InvalidOperationException("Could not find path to dot binary in any of: " + string.Join(", ", possibleLocations));
});
internal static string DotExePath => _DotExePath.Value;

public static RootGraph CreateLayout(Graph input, string engine = LayoutEngines.Dot, CoordinateSystem coordinateSystem = CoordinateSystem.BottomLeft)
Expand Down Expand Up @@ -74,18 +79,9 @@ public static (byte[] stdout, string stderr) Exec(Graph input, string format = "
}
string? inputToStdin = input.ToDotString();

// Get the location of the currently executing DLL
// https://learn.microsoft.com/en-us/dotnet/api/system.reflection.assembly.codebase?view=net-5.0
string exeDirectory = AppDomain.CurrentDomain.RelativeSearchPath
?? Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location)
?? Path.GetDirectoryName(System.AppContext.BaseDirectory);

// Construct the path to the executable
string exePath = Path.Combine(exeDirectory, DotExePath);

Process process = new Process();

process.StartInfo.FileName = exePath;
process.StartInfo.FileName = DotExePath;
process.StartInfo.Arguments = arguments;

// Redirect the input/output streams
Expand Down
Loading