-
Notifications
You must be signed in to change notification settings - Fork 207
Enhance the usage of Global Environment Vars #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chr1syy
wants to merge
10
commits into
RunMaestro:main
Choose a base branch
from
chr1syy:fix-global-env-var
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,819
−69
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
330f97f
fix: pass global shell environment variables to agent sessions
chr1syy 280e197
MAESTRO: add comprehensive test coverage for global environment varia…
chr1syy e226680
MAESTRO: Add comprehensive documentation for global environment varia…
chr1syy 8377b01
MAESTRO: Update UX and documentation for global environment variables…
chr1syy 814dcfe
MAESTRO: Phase 4 - UX and text changes for global environment variables
chr1syy d7a845f
MAESTRO: Fix unused shellEnvVars variable in process handler
chr1syy 0264487
fix: remove unused imports and add type guard for PATH in env builder…
chr1syy 7c38b3f
fix: move claude docs into maestro convention
chr1syy feca5a8
fix: remove more claude file creations
chr1syy 658f913
MAESTRO: Fix SSH and PTY spawner to apply global environment variables
chr1syy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a language tag to the fenced block.
The Global Environment Variables example should specify a language to satisfy MD040.
🔧 Suggested fix
Verify each finding against the current code and only fix it if needed.
In
@docs/configuration.mdaround lines 74 - 82, The fenced code block under"Example Configuration" lacks a language tag (triggering MD040); update the
triple-backtick fence for the environment variables example to include an "env"
language specifier (i.e., change
toenv) so the block containingANTHROPIC_API_KEY, HTTP_PROXY, HTTPS_PROXY, DEBUG, and MY_TOOL_PATH is fenced as
env.