fix: harden input validation, authentication, and P2P broadcast verification#1704
Merged
Cabecinha84 merged 4 commits intodevelopmentfrom Mar 26, 2026
Merged
fix: harden input validation, authentication, and P2P broadcast verification#1704Cabecinha84 merged 4 commits intodevelopmentfrom
Cabecinha84 merged 4 commits intodevelopmentfrom
Conversation
…check Ensure the target ip:port is a confirmed node on the network before making any outbound HTTP requests in isFluxAvailable.
Replace unary + operator with Number.isFinite() to prevent NaN bypass of the length limit check in getSvcRandomString.
Add verifyPrivilege('adminandfluxteam') checks to getEvents and
getEventsDisk to prevent unauthenticated access to syncthing event data.
Cross-reference the sender's public key against the node at the target IP in verifyFluxBroadcast, ensuring node operators can only broadcast messages about their own IP address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A collection of security hardening fixes across several FluxOS subsystems:
a confirmed node on the network before making any outbound HTTP requests in
isFluxAvailable, preventingSSRF-style abuse.
Number.isFinitefor syncthing random string length validation — Replace unary+operatorwith
Number.isFinite()to prevent NaN bypass of the length limit check ingetSvcRandomString.verifyPrivilege('adminandfluxteam')checksto
getEventsandgetEventsDiskto prevent unauthenticated access to syncthing event data.public key against the node at the target IP in
verifyFluxBroadcast, ensuring node operators can onlybroadcast messages about their own IP address.
Files changed
ZelBack/src/services/fluxCommunicationUtils.jsZelBack/src/services/fluxNetworkHelper.jsZelBack/src/services/syncthingService.js