Skip to content

fix: enable AndroidX support in gradle.properties #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vaibhav936 wants to merge 1 commit into from
Closed

fix: enable AndroidX support in gradle.properties #244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions examples/flutter/RunAnywhereAI/android/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,7 @@ distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.9-all.zip
org.gradle.jvmargs=-Xmx6g -XX:+UseG1GC -XX:MaxMetaspaceSize=512m -XX:+HeapDumpOnOutOfMemoryError -XX:+UseStringDeduplication -Dfile.encoding=UTF-8
org.gradle.daemon=true
org.gradle.parallel=true
org.gradle.configureondemand=true
Comment on lines +6 to +9
Copy link

@greptile-apps greptile-apps bot Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Wrong file for these settings. gradle-wrapper.properties is only for Gradle wrapper configuration (distribution URL, paths). These org.gradle.* build settings belong in gradle.properties at the project root (android/gradle.properties).

Additionally, the PR title mentions "enable AndroidX support" but no AndroidX settings (android.useAndroidX=true, android.enableJetifier=true) are included.

Create a new file at examples/flutter/RunAnywhereAI/android/gradle.properties with these settings instead.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: examples/flutter/RunAnywhereAI/android/gradle/wrapper/gradle-wrapper.properties
Line: 6:9

Comment:
**logic:** **Wrong file for these settings.** `gradle-wrapper.properties` is only for Gradle wrapper configuration (distribution URL, paths). These `org.gradle.*` build settings belong in `gradle.properties` at the project root (`android/gradle.properties`).

Additionally, the PR title mentions "enable AndroidX support" but no AndroidX settings (`android.useAndroidX=true`, `android.enableJetifier=true`) are included.

Create a new file at `examples/flutter/RunAnywhereAI/android/gradle.properties` with these settings instead.

How can I resolve this? If you propose a fix, please make it concise.

Copy link
Contributor

@sanchitmonga22 sanchitmonga22 Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check this @vaibhav936

Also, can you fix the downloading of the binaries and setting them? make sure it's part of the gradle and podspec in iOS to download those binaries automatically?

Copy link
Collaborator Author

@vaibhav936 vaibhav936 Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! sure am checking this.

Copy link
Contributor

@sanchitmonga22 sanchitmonga22 Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this change and PR? can we please close it if not needed?