Skip to content
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import androidx.compose.foundation.layout.size
import androidx.compose.foundation.layout.width
import androidx.compose.foundation.shape.CircleShape
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.filled.*
import androidx.compose.material.icons.filled.AutoAwesome
import androidx.compose.material.icons.filled.GraphicEq
import androidx.compose.material.icons.filled.Lock
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.foundation.text.KeyboardOptions
import androidx.compose.foundation.verticalScroll
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.filled.*
import androidx.compose.material.icons.outlined.*
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant wildcard imports alongside specific imports

These wildcard imports (filled.*, outlined.*) make the specific named imports below them (e.g., filled.Analytics, filled.CleaningServices) redundant. Either use only the wildcard imports and remove the named ones, or remove the wildcards and keep only the specific imports (preferred for clarity and avoiding unused import warnings).

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix With AI
This is a comment left during a code review.
Path: examples/android/RunAnywhereAI/app/src/main/java/com/runanywhere/runanywhereai/presentation/settings/SettingsScreen.kt
Line: 18-19

Comment:
**Redundant wildcard imports alongside specific imports**

These wildcard imports (`filled.*`, `outlined.*`) make the specific named imports below them (e.g., `filled.Analytics`, `filled.CleaningServices`) redundant. Either use only the wildcard imports and remove the named ones, or remove the wildcards and keep only the specific imports (preferred for clarity and avoiding unused import warnings).

<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>

How can I resolve this? If you propose a fix, please make it concise.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not Something big but would be really Good if removed 😊

import androidx.compose.material.icons.filled.Analytics
import androidx.compose.material.icons.filled.CleaningServices
import androidx.compose.material.icons.filled.CloudQueue
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import 'package:runanywhere_ai/features/models/model_selection_sheet.dart';
import 'package:runanywhere_ai/features/models/model_status_components.dart';
import 'package:runanywhere_ai/features/models/model_types.dart';
import 'package:runanywhere_ai/features/settings/tool_settings_view_model.dart';
import 'package:runanywhere_ai/features/structured_output/structured_output_view.dart';
import 'package:shared_preferences/shared_preferences.dart';

/// ChatInterfaceView (mirroring iOS ChatInterfaceView.swift)
Expand Down Expand Up @@ -452,7 +453,18 @@ class _ChatInterfaceViewState extends State<ChatInterfaceView> {
return Scaffold(
appBar: AppBar(
title: const Text('Chat'),
actions: [
actions: [
IconButton(
icon: const Icon(Icons.data_object),
onPressed: () {
Navigator.of(context).push<void>(
MaterialPageRoute<void>(
builder: (context) => const StructuredOutputView(),
),
);
},
tooltip: 'Structured Output Examples',
),
if (_messages.isNotEmpty)
IconButton(
icon: const Icon(Icons.delete_outline),
Expand Down
Loading
Loading