Add code fixer for tab order #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle scenarios without docking, e.g. all controls that have misaligned `TabIndex` vs z-order aren't docked. There are three distinct scenarios when it comes to re-ordering statements: 1. Move down by one, or swap neighbouring statements - in this case we need to swap the leading trivia before we switch. 2. Move down by more than one position - we need to swap leading trivia with the statement directly below the statement we are moving, and update the trivia for the moved statement with the leading trivia of the statement above which we're inserting. 3. Move up - we need to swap the leading trivia for the moved statement with the leading trivia of the statement above which we're inserting, and update that statement's trivia with the leading trivia of the statement directly below it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle scenarios without docking, e.g. all controls that have misaligned
TabIndexvs z-order aren't docked.There are three distinct scenarios when it comes to re-ordering statements:
1. Move down by one, or swap neighbouring statements
In this case we need to swap the leading trivia before we switch.
E.g.:
// // Form1 // + this.Controls.Add(button3); this.Controls.Add(this.button1); - this.Controls.Add(button3); this.Controls.Add(this.button2); this.ResumeLayout(false);The leading trivia of the the moved statement is:
// // Form1 //2. Move down by more than one position.
We need to swap leading trivia with the statement directly below the statement we are moving, and update the trivia for the moved statement with the leading trivia of the statement above which we're inserting.
E.g.:
// // Form1 // - this.Controls.Add(this.button2); this.Controls.Add(button3); this.Controls.Add(this.button1); + this.Controls.Add(this.button2); this.Controls.Add(this.treeView1); this.ResumeLayout(false);The leading trivia of the the moved statement is:
// // Form1 //3. Move up
We need to swap the leading trivia for the moved statement with the leading trivia of the statement above which we're inserting, and update that statement's trivia with the leading trivia of the statement directly below it.
E.g.:
// // Form1 // + this.Controls.Add(this.treeView1); this.Controls.Add(button3); this.Controls.Add(this.button1); this.Controls.Add(this.button2); - this.Controls.Add(this.treeView1); this.ResumeLayout(false);The leading trivia of the the statement above which we're inserting is
// // Form1 //