Finish up subpattern codegen support for identifier patterns #4072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terns
Trimmed GIMPLE code gen for let-identifierpattern-subpattern.rs
...
RUSTTMP.1.__0 = 0;
RUSTTMP.1.__1 = 2;
RUSTTMP.1.__2 = 3;
bar = RUSTTMP.1.__0;
RUSTTMP.2 = RUSTTMP.1.__1;
RUSTTMP.3 = RUSTTMP.1.__2;
foo.__0 = 0;
foo.__1 = 2;
foo.__2 = 3;
ret = 1;
RUSTTMP.5 = foo;
_1 = RUSTTMP.5.__0;
_2 = _1 == 0;
_3 = RUSTTMP.5.__1;
_4 = _3 == 2;
_5 = _2 & _4;
_6 = RUSTTMP.5.__2;
_7 = _6 == 3;
_8 = _5 & _7;
if (_8 != 0) goto <D.143>; else goto <D.144>;
<D.143>:
{
{
ret = bar;
}
goto <D.137>;
}
...
gcc/rust/ChangeLog:
* backend/rust-compile-pattern.cc(CompilePatternLet::visit(IdentifierPattern)):
Add support for subpatterns.
* backend/rust-compile-var-decl.h(CompileVarDecl::visit(IdentifierPattern)):
Implement compilation for subpatterns.
Signed-off-by: Yap Zhi Heng <[email protected]>
gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc(ClosureParamInfer(IdentifierPattern)): Resolve subpattern types for IdentifierPattern. Signed-off-by: Yap Zhi Heng <[email protected]>
Polygonalr
force-pushed
the
identifier-pattern-sub-decl
branch
from
e16ace6 to
fc9502d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
letstatement binding support for identifier patterns' subpatterns, together with closure param bindings as well (albeit untested because of #4071)