nr2.0: Fix ChangeLog entry #4075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"options.txt" was supposed to be "options.h". Signed-off-by: Owen Avery <[email protected]>
|
I blame video games |
|
Changelog are generated, I must say that I haven't seen anyone changing them manually (yet). @tschwinge @dkm Is this accepted ? |
P-E-P
approved these changes
Aug 13, 2025
There was a problem hiding this comment.
Ok so, multiple things here @CohenArthur
- This contribution must not include any changelog entry ( ✅ )
- Contribution has already hit upstream, we cannot amend the commit before the next upstream cycle
- The commit must not change any other file ( ✅ )
Commit looks good.
|
As far as I remember, it's permissible to have a commit modify |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"options.txt" was supposed to be "options.h".