derive: Implement make_qualified_call helper #4394
Open
+15
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pasta-coder
force-pushed
the
refactor/derive-clone-helper
branch
2 times, most recently
from
1229281 to
d7df9ae
Compare
CohenArthur
reviewed
Jan 18, 2026
Pasta-coder
force-pushed
the
refactor/derive-clone-helper
branch
3 times, most recently
from
5631aa0 to
7128540
Compare
Contributor
Author
|
@CohenArthur , i got it , thanks for the review . i applied the requested changed . |
CohenArthur
approved these changes
Jan 19, 2026
Member
CohenArthur
left a comment
CohenArthur
left a comment
There was a problem hiding this comment.
Looks good thank you! Just a few fixes and we can merge this
This patch implements the `qualified_call` helper method in the `Builder` class. This logic was previously intended to be a local helper in `DeriveClone`, but moving it to the `Builder` allows it to be reused across the compiler for constructing qualified function calls. It updates `DeriveClone::clone_call` to use this new `Builder` method, simplifying the code and resolving the TODO. Fixes Rust-GCC#4393 gcc/rust/ChangeLog: * ast/rust-ast-builder.h (Builder::qualified_call): New method declaration. * ast/rust-ast-builder.cc (Builder::qualified_call): Implement new method. * expand/rust-derive-clone.cc (DeriveClone::clone_call): Use builder.qualified_call. Signed-off-by: Jayant Chauhan <0001jayant@gmail.com>
Pasta-coder
force-pushed
the
refactor/derive-clone-helper
branch
from
7128540 to
515b5a8
Compare
Contributor
Author
|
@CohenArthur please review . thnakyou . |
P-E-P
reviewed
Jan 26, 2026
|
|
||
| // Not sure how to call it properly in the meantime... | ||
|
|
||
| auto path = std::unique_ptr<Expr> ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements the make_qualified_call helper function as requested by the TODO in rust-derive-clone.cc. It refactors DeriveClone::clone_call to use this new helper, simplifying the construction of qualified paths for function calls.
Fixes #4393
gcc/rust/ChangeLog: