Reduce node id sharing #4408
Open
Reduce node id sharing #4408
+61
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes some redundant copies and improves TypePath copying. gcc/rust/ChangeLog: * ast/rust-ast-builder.cc (Builder::trait_bound): Replace copy with move. (Builder::trait_impl): Likewise. (Builder::new_const_param): Replace cloning with reconstruction. * ast/rust-path.h (TypePath::TypePath): Use TypeNoBounds copy constructor. (TypePath::operator=): Use TypeNoBounds copy assignment. * expand/rust-derive-clone.cc (DeriveClone::clone_impl): Produce trait bounds lazily. * expand/rust-derive-copy.cc (DeriveCopy::copy_impl): Likewise. * expand/rust-derive-debug.cc (DeriveDebug::stub_derive_impl): Likewise. * expand/rust-derive-default.cc (DeriveDefault::default_impl): Likewise. * expand/rust-derive-eq.cc (DeriveEq::eq_impls): Likewise. * expand/rust-derive-hash.cc (DeriveHash::hash_impl): Likewise. * expand/rust-derive-ord.cc (DeriveOrd::cmp_impl): Likewise. * expand/rust-derive-partial-eq.cc (DerivePartialEq::partialeq_impls): Likewise. * expand/rust-derive.cc (DeriveVisitor::setup_impl_generics): Likewise. * expand/rust-derive.h (DeriveVisitor::setup_impl_generics): Likewise. Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
powerboat9
force-pushed
the
fix-id-dupe
branch
from
0a026a9 to
febf2cf
Compare
P-E-P
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes some redundant copies and improves TypePath copying.
This should prevent the compiler from ICE-ing before it hits the lowering phase.