parse: Fix ICE when using 'dyn' without trait bound#4421
Merged
P-E-P merged 1 commit intoRust-GCC:masterfrom Feb 4, 2026
Merged
parse: Fix ICE when using 'dyn' without trait bound#4421P-E-P merged 1 commit intoRust-GCC:masterfrom
P-E-P merged 1 commit intoRust-GCC:masterfrom
Conversation
Contributor
Author
|
I am not CI friendly btw :) |
Islam-Imad
force-pushed
the
bugfix/issue-3905-dyn-type-error
branch
from
a0bea3e to
42623ef
Compare
Contributor
Author
|
@P-E-P any feedback ? |
The parser was accepting 'dyn' as a standalone type in contexts like: static STATIC_1: dyn = 1; This invalid syntax should be rejected at parse time. Fixes Rust-GCC#3905 gcc/rust/ChangeLog: * lex/rust-lex.cc (is_whitespace): refactor if-else to switch * lex/rust-token.h: refactor if-else to switch * parse/rust-parse-impl.hxx: return nullptr when type is in invalid state gcc/testsuite/ChangeLog: * rust/compile/issue-3904.rs: refactor the testcase to match the new thrown error Signed-off-by: Islam-Imad <islamimad404@gmail.com>
Islam-Imad
force-pushed
the
bugfix/issue-3905-dyn-type-error
branch
from
42623ef to
0063e02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3905
The parser was accepting
dynas a standalone type in contexts like:static STATIC_1: dyn = 1;also preferred to refactor some if-else stms into switch/case