Deduplicate some functions within PointerVisitor#4489
Open
P-E-P wants to merge 1 commit intoRust-GCC:masterfrom
Open
Deduplicate some functions within PointerVisitor#4489P-E-P wants to merge 1 commit intoRust-GCC:masterfrom
P-E-P wants to merge 1 commit intoRust-GCC:masterfrom
Conversation
Some functions within the PointerVisitor were obvious duplicate from the inherited DefaultASTVisitor. gcc/rust/ChangeLog: * ast/rust-ast-pointer-visitor.cc (PointerVisitor::visit): Remove duplicated functions. * ast/rust-ast-pointer-visitor.h: Remove duplicated function prototypes. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
powerboat9
requested changes
Mar 19, 2026
| void | ||
| PointerVisitor::visit (AST::AttrInputMacro &attr_input) | ||
| { | ||
| visit (attr_input.get_macro ()); |
Collaborator
There was a problem hiding this comment.
I'm not sure we should remove this -- seems like we'll eventually want AttrInputMacro to be an ~AttrInputExpr
| void | ||
| PointerVisitor::visit (AST::MetaItemLitExpr &meta_item) | ||
| { | ||
| visit (meta_item.get_literal ()); |
| PointerVisitor::visit (AST::StructPatternElements &spe) | ||
| { | ||
| for (auto &field : spe.get_struct_pattern_fields ()) | ||
| visit (field); |
Collaborator
There was a problem hiding this comment.
this should probably be reseat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some functions within the PointerVisitor were obvious duplicate from the inherited DefaultASTVisitor.