Major refactor #27
Open
Major refactor #27
+2,074
−473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed some cli options, drop the "short" tag for github_project_owner.
With the "upstream" command, we can create a PR to use the existing CI. This PR should target the upstream base revision, so this new --github-upstream-base is used to get the name of this new branch and the upstream revision is used and pushed on the remote.
As the branch does not exist locally, need to add the extra refs/heads prefix.
It's probably better to have this as a setting in .ssh/config, or export GIT_SSH_COMMAND before invoking gerris: https://git-scm.com/docs/git#Documentation/git.txt-GITSSHCOMMAND
All options can be set in the config file. Command line options override values from the config file, if any. Makes the default values a bit hidden (previously handled by clap).
Use --add-missing-prefix, or the add_missing_prefix setting in the config file to have gerris automatically add missing prefixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major refactor.