Rearrange examples and disable Optix crates #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnethercote
force-pushed
the
disable-optix
branch
3 times, most recently
from
9e4ad29 to
8402f06
Compare
Currently the top-level `Cargo.toml` lists members both explicitly (direct naming) and implicitly (using globs). The latter is annoying, and makes it hard to tell what the actual packages in the workspace are, particularly with the complex `cargo --workspace --exclude` invocations in CI. This commit makes all the member explicit and puts them in alphabetical order.
For consistency with the examples in `examples/` and `samples/`, which all put their kernel code in `kernels/`.
For consistency with the examples in `examples/` and `samples/`, which all put their kernel code in `kernels/`.
Alongside all the other OptiX examples.
Now that the `examples/optix/` directory is gone, the `cuda/` subdirectory isn't needed.
Because it uses OptiX.
nnethercote
force-pushed
the
disable-optix
branch
from
8402f06 to
594d24f
Compare
Because they don't work without OptiX, which is less important than CUDA and a pain to install. This means we don't have to manually exclude all these crates in CI, which is nice -- e.g. a vanilla `cargo build --workspace` works. Also, on Linux we don't need `--exclude "cudnn*"`. (We still need it on Windows.)
nnethercote
force-pushed
the
disable-optix
branch
from
594d24f to
37396a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having to manually exclude the OptiX crates is a pain. Let's just comment them out in the top-level
Cargo.toml.And before doing that, let's rearrange that top-level
Cargo.tomland the examples to make things much clearer, e.g. putting all the OptiX-dependent examples in the same directory.