Remove long-obsolete is_blocklisted_fn mechanism.
#267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whatever it was meant to protect against, seems to be long gone, so this was just wastefully pattern-matching all monomorphic function instances against e.g.
<_ as core::fmt::Debug>::fmt.Ran into the zombie1 it introduces when declaring a "blocklisted" function, and I was going to move that around so it at least always generates an
OpFunction, but nothing broke when removing the check entirely.1 (
OpUndefof typeOpTypeFunctionis already pretty sketchy, but it's even worse when passed to instructions that expect the ID of anOpFunction, not just "some value of function type")