Support more test names in difftest #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These all now work. Previously, the path ones did not work: - cargo difftest -- difftests::arch::workgroup_memory (original format) - cargo difftest -- arch/workgroup_memory (path-like format) - cargo difftest -- arch (directory filter)
Firestar99
requested changes
Jul 2, 2025
Member
Firestar99
left a comment
Firestar99
left a comment
There was a problem hiding this comment.
Why does this not work?
cargo difftest difftests/simple
works:
cargo difftest difftests::simplecargo difftest simplecargo difftest difftests
Firestar99
approved these changes
Jul 2, 2025
Member
Firestar99
left a comment
Firestar99
left a comment
There was a problem hiding this comment.
You were always preprending difftests:: so difftests/simple turned into difftests::difftests::simple. I removed that prepend, though that means arch would run a test named difftest::bla::test::bla_test_arch. But since we haven't encountered that issue with compiletest either, I don't think that's a huge deal.
Collaborator
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These all now work. Previously, the path ones did not work: