Rewrite the ash runner #419
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firestar99
force-pushed
the
simplify-ash-runner2
branch
from
19159e1 to
0e10f07
Compare
nnethercote
reviewed
Sep 30, 2025
nnethercote
reviewed
Sep 30, 2025
nnethercote
reviewed
Sep 30, 2025
|
Thanks for cleaning this up, I don't understand everything about this code but the parts I do understand look good. I can see you've generally improved the error handling, fixed a bunch of "FIXME" comments, etc. It would be nice to have some commit messages that are more than a single line. The "ash runner: rewrite" commit in particular changes a lot of code with zero explanation. |
* use Vulkan 1.3 * use DynamicRendering feature replacing Framebuffers * extract `MyDevice` struct containing vk initialization * decouple rendering from swapchain management * redo swapchain sync, fixes validation errors, intentionally kept basic * make rendering lazily recreate its pipeline
Firestar99
force-pushed
the
simplify-ash-runner2
branch
from
0e10f07 to
def7735
Compare
Firestar99
force-pushed
the
simplify-ash-runner2
branch
from
6597b17 to
3007d25
Compare
MarijnS95
reviewed
Oct 2, 2025
examples/runners/ash/src/device.rs
Outdated
Comment on lines
173
to
177
| let message_id_name = if callback_data.p_message_id_name.is_null() { | ||
| Cow::from("") | ||
| } else { | ||
| unsafe { CStr::from_ptr(callback_data.p_message_id_name).to_string_lossy() } | ||
| }; |
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks, I very much would! I think that section is just copied from the old runner :D
Firestar99
force-pushed
the
simplify-ash-runner2
branch
from
2c6bab2 to
fb61b79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup from #418
I've noticed that running the ash runner with debug layers enabled (
--debug-layers) prints tons of validation errors, all of which should be considered programming errors and sort of equivalent to a runtime panic. Instead of trying to fix what is there, I decided to completely rewrite the ash runner instead, and update it to the modern Vulkan 1.3 way you'd render things.MyDevicestruct containing vk initializationMacOS: removes the
ash-moltendependency, which means we now require MoltenVK (or the Vulkan SDK) to be installed on MacOS for the ash runner to work. The wgpu runner still works as normal, with the metal backend.Reviews
Please test this on your machine with validation layers turned on, if possible (requires the Vulkan SDK). Report back if it runs and on which OS and graphics card.
Note:
--shader=sky: holding arrow keys should change brightness--shader=mouse: should be animated--debug-layerrequires vulkan sdk