Skip to content

Commit 00b4361

Browse files
nxpfrankliShawn Guo
authored andcommitted
arm64: dts: imx8qm-ss-dma: fix can lpcg indices
can1_lpcg: clock-controller@5ace0000 { ... Col1 Col2 clocks = <&clk IMX_SC_R_CAN_1 IMX_SC_PM_CLK_PER>,// 0 0 <&dma_ipg_clk>, // 1 4 <&dma_ipg_clk>; // 2 5 clock-indices = <IMX_LPCG_CLK_0>, <IMX_LPCG_CLK_4>, <IMX_LPCG_CLK_5>; }; Col1: index, which existing dts try to get. Col2: actual index in lpcg driver &flexcan2 { clocks = <&can1_lpcg 1>, <&can1_lpcg 0>; ^^ ^^ Should be: clocks = <&can1_lpcg IMX_LPCG_CLK_4>, <&can1_lpcg IMX_LPCG_CLK_0>; }; Arg0 is divided by 4 in lpcg driver. So flexcan get IMX_SC_PM_CLK_PER by <&can1_lpcg 1> and <&can1_lpcg 0>. Although function work, code logic is wrong. Fix it by using correct clock indices. Cc: [email protected] Fixes: be85831 ("arm64: dts: imx8qm: add can node in devicetree") Signed-off-by: Frank Li <[email protected]> Signed-off-by: Shawn Guo <[email protected]>
1 parent 0893392 commit 00b4361

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -153,15 +153,15 @@
153153
};
154154

155155
&flexcan2 {
156-
clocks = <&can1_lpcg 1>,
157-
<&can1_lpcg 0>;
156+
clocks = <&can1_lpcg IMX_LPCG_CLK_4>,
157+
<&can1_lpcg IMX_LPCG_CLK_0>;
158158
assigned-clocks = <&clk IMX_SC_R_CAN_1 IMX_SC_PM_CLK_PER>;
159159
fsl,clk-source = /bits/ 8 <1>;
160160
};
161161

162162
&flexcan3 {
163-
clocks = <&can2_lpcg 1>,
164-
<&can2_lpcg 0>;
163+
clocks = <&can2_lpcg IMX_LPCG_CLK_4>,
164+
<&can2_lpcg IMX_LPCG_CLK_0>;
165165
assigned-clocks = <&clk IMX_SC_R_CAN_2 IMX_SC_PM_CLK_PER>;
166166
fsl,clk-source = /bits/ 8 <1>;
167167
};

0 commit comments

Comments
 (0)