@@ -256,11 +256,11 @@ static unsigned int dw_pcie_ep_get_rebar_offset(struct dw_pcie *pci,
256
256
return offset ;
257
257
258
258
reg = dw_pcie_readl_dbi (pci , offset + PCI_REBAR_CTRL );
259
- nbars = ( reg & PCI_REBAR_CTRL_NBAR_MASK ) >> PCI_REBAR_CTRL_NBAR_SHIFT ;
259
+ nbars = FIELD_GET ( PCI_REBAR_CTRL_NBAR_MASK , reg ) ;
260
260
261
261
for (i = 0 ; i < nbars ; i ++ , offset += PCI_REBAR_CTRL ) {
262
262
reg = dw_pcie_readl_dbi (pci , offset + PCI_REBAR_CTRL );
263
- bar_index = reg & PCI_REBAR_CTRL_BAR_IDX ;
263
+ bar_index = FIELD_GET ( PCI_REBAR_CTRL_BAR_IDX , reg ) ;
264
264
if (bar_index == bar )
265
265
return offset ;
266
266
}
@@ -672,7 +672,7 @@ static const struct pci_epc_ops epc_ops = {
672
672
* @ep: DWC EP device
673
673
* @func_no: Function number of the endpoint
674
674
*
675
- * Return: 0 if success, errono otherwise.
675
+ * Return: 0 if success, errno otherwise.
676
676
*/
677
677
int dw_pcie_ep_raise_intx_irq (struct dw_pcie_ep * ep , u8 func_no )
678
678
{
@@ -691,7 +691,7 @@ EXPORT_SYMBOL_GPL(dw_pcie_ep_raise_intx_irq);
691
691
* @func_no: Function number of the endpoint
692
692
* @interrupt_num: Interrupt number to be raised
693
693
*
694
- * Return: 0 if success, errono otherwise.
694
+ * Return: 0 if success, errno otherwise.
695
695
*/
696
696
int dw_pcie_ep_raise_msi_irq (struct dw_pcie_ep * ep , u8 func_no ,
697
697
u8 interrupt_num )
@@ -876,8 +876,7 @@ static void dw_pcie_ep_init_non_sticky_registers(struct dw_pcie *pci)
876
876
877
877
if (offset ) {
878
878
reg = dw_pcie_readl_dbi (pci , offset + PCI_REBAR_CTRL );
879
- nbars = (reg & PCI_REBAR_CTRL_NBAR_MASK ) >>
880
- PCI_REBAR_CTRL_NBAR_SHIFT ;
879
+ nbars = FIELD_GET (PCI_REBAR_CTRL_NBAR_MASK , reg );
881
880
882
881
/*
883
882
* PCIe r6.0, sec 7.8.6.2 require us to support at least one
@@ -898,7 +897,7 @@ static void dw_pcie_ep_init_non_sticky_registers(struct dw_pcie *pci)
898
897
* is why RESBAR_CAP_REG is written here.
899
898
*/
900
899
val = dw_pcie_readl_dbi (pci , offset + PCI_REBAR_CTRL );
901
- bar = val & PCI_REBAR_CTRL_BAR_IDX ;
900
+ bar = FIELD_GET ( PCI_REBAR_CTRL_BAR_IDX , val ) ;
902
901
if (ep -> epf_bar [bar ])
903
902
pci_epc_bar_size_to_rebar_cap (ep -> epf_bar [bar ]-> size , & val );
904
903
else
0 commit comments