Skip to content

Commit 039adf3

Browse files
drm/i915: More use of GT specific print helpers
Update a bunch of GT related print messages in non-GT files to use the GT specific helpers. Signed-off-by: John Harrison <[email protected]> Reviewed-by: Andi Shyti <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent e96aef0 commit 039adf3

File tree

3 files changed

+9
-10
lines changed

3 files changed

+9
-10
lines changed

drivers/gpu/drm/i915/gt/uc/intel_gsc_uc.c

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,7 @@ static void gsc_work(struct work_struct *work)
6868
* A proxy failure right after firmware load means the proxy-init
6969
* step has failed so mark GSC as not usable after this
7070
*/
71-
drm_err(&gt->i915->drm,
72-
"GSC proxy handler failed to init\n");
71+
gt_err(gt, "GSC proxy handler failed to init\n");
7372
intel_uc_fw_change_status(&gsc->fw, INTEL_UC_FIRMWARE_LOAD_FAIL);
7473
}
7574
goto out_put;
@@ -83,11 +82,10 @@ static void gsc_work(struct work_struct *work)
8382
* status register to check if the proxy init was actually successful
8483
*/
8584
if (intel_gsc_uc_fw_proxy_init_done(gsc, false)) {
86-
drm_dbg(&gt->i915->drm, "GSC Proxy initialized\n");
85+
gt_dbg(gt, "GSC Proxy initialized\n");
8786
intel_uc_fw_change_status(&gsc->fw, INTEL_UC_FIRMWARE_RUNNING);
8887
} else {
89-
drm_err(&gt->i915->drm,
90-
"GSC status reports proxy init not complete\n");
88+
gt_err(gt, "GSC status reports proxy init not complete\n");
9189
intel_uc_fw_change_status(&gsc->fw, INTEL_UC_FIRMWARE_LOAD_FAIL);
9290
}
9391
}

drivers/gpu/drm/i915/i915_driver.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@
7171
#include "gem/i915_gem_pm.h"
7272
#include "gt/intel_gt.h"
7373
#include "gt/intel_gt_pm.h"
74+
#include "gt/intel_gt_print.h"
7475
#include "gt/intel_rc6.h"
7576

7677
#include "pxp/intel_pxp.h"
@@ -425,7 +426,7 @@ static int i915_pcode_init(struct drm_i915_private *i915)
425426
for_each_gt(gt, i915, id) {
426427
ret = intel_pcode_init(gt->uncore);
427428
if (ret) {
428-
drm_err(&gt->i915->drm, "gt%d: intel_pcode_init failed %d\n", id, ret);
429+
gt_err(gt, "intel_pcode_init failed %d\n", ret);
429430
return ret;
430431
}
431432
}

drivers/gpu/drm/i915/i915_perf.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,7 @@
206206
#include "gt/intel_gt.h"
207207
#include "gt/intel_gt_clock_utils.h"
208208
#include "gt/intel_gt_mcr.h"
209+
#include "gt/intel_gt_print.h"
209210
#include "gt/intel_gt_regs.h"
210211
#include "gt/intel_lrc.h"
211212
#include "gt/intel_lrc_reg.h"
@@ -1659,9 +1660,8 @@ static void i915_oa_stream_destroy(struct i915_perf_stream *stream)
16591660
free_noa_wait(stream);
16601661

16611662
if (perf->spurious_report_rs.missed) {
1662-
drm_notice(&gt->i915->drm,
1663-
"%d spurious OA report notices suppressed due to ratelimiting\n",
1664-
perf->spurious_report_rs.missed);
1663+
gt_notice(gt, "%d spurious OA report notices suppressed due to ratelimiting\n",
1664+
perf->spurious_report_rs.missed);
16651665
}
16661666
}
16671667

@@ -1852,7 +1852,7 @@ static int alloc_oa_buffer(struct i915_perf_stream *stream)
18521852
*/
18531853
ret = i915_vma_pin(vma, 0, SZ_16M, PIN_GLOBAL | PIN_HIGH);
18541854
if (ret) {
1855-
drm_err(&gt->i915->drm, "Failed to pin OA buffer %d\n", ret);
1855+
gt_err(gt, "Failed to pin OA buffer %d\n", ret);
18561856
goto err_unref;
18571857
}
18581858

0 commit comments

Comments
 (0)