Skip to content

Commit 06ccf63

Browse files
tpm_eventlog.h: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on. Also, notice that, dynamic memory allocations won't be affected by this change: "Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1] This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] KSPP#21 [3] commit 7649773 ("cxgb3/l2t: Fix undefined behaviour") Signed-off-by: Gustavo A. R. Silva <[email protected]>
1 parent 4ea19ec commit 06ccf63

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

include/linux/tpm_eventlog.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ struct tcpa_event {
2828
u32 event_type;
2929
u8 pcr_value[20]; /* SHA1 */
3030
u32 event_size;
31-
u8 event_data[0];
31+
u8 event_data[];
3232
};
3333

3434
enum tcpa_event_types {
@@ -55,7 +55,7 @@ enum tcpa_event_types {
5555
struct tcpa_pc_event {
5656
u32 event_id;
5757
u32 event_size;
58-
u8 event_data[0];
58+
u8 event_data[];
5959
};
6060

6161
enum tcpa_pc_event_ids {
@@ -102,7 +102,7 @@ struct tcg_pcr_event {
102102

103103
struct tcg_event_field {
104104
u32 event_size;
105-
u8 event[0];
105+
u8 event[];
106106
} __packed;
107107

108108
struct tcg_pcr_event2_head {

0 commit comments

Comments
 (0)