Skip to content

Commit 0c625cc

Browse files
jwrdegoedelinusw
authored andcommitted
gpiolib: acpi: Add quirk to ignore EC wakeups on HP x2 10 CHT + AXP288 model
There are at least 3 models of the HP x2 10 models: Bay Trail SoC + AXP288 PMIC Cherry Trail SoC + AXP288 PMIC Cherry Trail SoC + TI PMIC Like on the other HP x2 10 models we need to ignore wakeup for ACPI GPIO events on the external embedded-controller pin to avoid spurious wakeups on the HP x2 10 CHT + AXP288 model too. This commit adds an extra DMI based quirk for the HP x2 10 CHT + AXP288 model, ignoring wakeups for ACPI GPIO events on the EC interrupt pin on this model. This fixes spurious wakeups from suspend on this model. Fixes: aa23ca3 ("gpiolib: acpi: Add honor_wakeup module-option + quirk mechanism") Reported-and-tested-by: Marc Lehmann <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Link: https://lore.kernel.org/r/[email protected] Acked-by: Mika Westerberg <[email protected]> Signed-off-by: Linus Walleij <[email protected]>
1 parent 0e91506 commit 0c625cc

File tree

1 file changed

+15
-0
lines changed

1 file changed

+15
-0
lines changed

drivers/gpio/gpiolib-acpi.c

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1437,6 +1437,21 @@ static const struct dmi_system_id gpiolib_acpi_quirks[] = {
14371437
.ignore_wake = "INT33FC:02@28",
14381438
},
14391439
},
1440+
{
1441+
/*
1442+
* HP X2 10 models with Cherry Trail SoC + AXP288 PMIC use an
1443+
* external embedded-controller connected via I2C + an ACPI GPIO
1444+
* event handler on INT33FF:01 pin 0, causing spurious wakeups.
1445+
*/
1446+
.matches = {
1447+
DMI_MATCH(DMI_SYS_VENDOR, "HP"),
1448+
DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion x2 Detachable"),
1449+
DMI_MATCH(DMI_BOARD_NAME, "813E"),
1450+
},
1451+
.driver_data = &(struct acpi_gpiolib_dmi_quirk) {
1452+
.ignore_wake = "INT33FF:01@0",
1453+
},
1454+
},
14401455
{} /* Terminating entry */
14411456
};
14421457

0 commit comments

Comments
 (0)