Skip to content

Commit 0e36fd4

Browse files
committed
Merge tag 'char-misc-5.7-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc
Pull char/misc fixes from Greg KH: "Here are some small char/misc driver fixes for 5.7-rc7 that resolve some reported issues. Included in here are tiny fixes for the mei, coresight, rtsx, ipack, and mhi drivers. All of these have been in linux-next with no reported issues" * tag 'char-misc-5.7-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc: misc: rtsx: Add short delay after exit from ASPM bus: mhi: core: Fix some error return code ipack: tpci200: fix error return code in tpci200_register() coresight: cti: remove incorrect NULL return check mei: release me_cl object reference
2 parents 8f26104 + 7a839db commit 0e36fd4

File tree

5 files changed

+10
-2
lines changed

5 files changed

+10
-2
lines changed

drivers/bus/mhi/core/init.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -291,6 +291,7 @@ int mhi_init_dev_ctxt(struct mhi_controller *mhi_cntrl)
291291
}
292292

293293
/* Setup cmd context */
294+
ret = -ENOMEM;
294295
mhi_ctxt->cmd_ctxt = mhi_alloc_coherent(mhi_cntrl,
295296
sizeof(*mhi_ctxt->cmd_ctxt) *
296297
NR_OF_CMD_RINGS,
@@ -1100,6 +1101,7 @@ static int mhi_driver_probe(struct device *dev)
11001101
}
11011102
}
11021103

1104+
ret = -EINVAL;
11031105
if (dl_chan) {
11041106
/*
11051107
* If channel supports LPM notifications then status_cb should

drivers/hwtracing/coresight/coresight-cti-platform.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ static int cti_plat_create_v8_etm_connection(struct device *dev,
120120

121121
/* Can optionally have an etm node - return if not */
122122
cs_fwnode = fwnode_find_reference(root_fwnode, CTI_DT_CSDEV_ASSOC, 0);
123-
if (IS_ERR_OR_NULL(cs_fwnode))
123+
if (IS_ERR(cs_fwnode))
124124
return 0;
125125

126126
/* allocate memory */
@@ -393,7 +393,7 @@ static int cti_plat_create_connection(struct device *dev,
393393
/* associated device ? */
394394
cs_fwnode = fwnode_find_reference(fwnode,
395395
CTI_DT_CSDEV_ASSOC, 0);
396-
if (!IS_ERR_OR_NULL(cs_fwnode)) {
396+
if (!IS_ERR(cs_fwnode)) {
397397
assoc_name = cti_plat_get_csdev_or_node_name(cs_fwnode,
398398
&csdev);
399399
fwnode_handle_put(cs_fwnode);

drivers/ipack/carriers/tpci200.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -306,6 +306,7 @@ static int tpci200_register(struct tpci200_board *tpci200)
306306
"(bn 0x%X, sn 0x%X) failed to map driver user space!",
307307
tpci200->info->pdev->bus->number,
308308
tpci200->info->pdev->devfn);
309+
res = -ENOMEM;
309310
goto out_release_mem8_space;
310311
}
311312

drivers/misc/cardreader/rtsx_pcr.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,9 @@ static void rtsx_comm_pm_full_on(struct rtsx_pcr *pcr)
142142

143143
rtsx_disable_aspm(pcr);
144144

145+
/* Fixes DMA transfer timout issue after disabling ASPM on RTS5260 */
146+
msleep(1);
147+
145148
if (option->ltr_enabled)
146149
rtsx_set_ltr_latency(pcr, option->ltr_active_latency);
147150

drivers/misc/mei/client.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -266,6 +266,7 @@ void mei_me_cl_rm_by_uuid(struct mei_device *dev, const uuid_le *uuid)
266266
down_write(&dev->me_clients_rwsem);
267267
me_cl = __mei_me_cl_by_uuid(dev, uuid);
268268
__mei_me_cl_del(dev, me_cl);
269+
mei_me_cl_put(me_cl);
269270
up_write(&dev->me_clients_rwsem);
270271
}
271272

@@ -287,6 +288,7 @@ void mei_me_cl_rm_by_uuid_id(struct mei_device *dev, const uuid_le *uuid, u8 id)
287288
down_write(&dev->me_clients_rwsem);
288289
me_cl = __mei_me_cl_by_uuid_id(dev, uuid, id);
289290
__mei_me_cl_del(dev, me_cl);
291+
mei_me_cl_put(me_cl);
290292
up_write(&dev->me_clients_rwsem);
291293
}
292294

0 commit comments

Comments
 (0)