Skip to content

Commit 11b45b0

Browse files
Lai Jiangshanhtejun
authored andcommitted
workqueue: Remove outdated comment about exceptional workers in unbind_workers()
Long time before, workers are not ALL bound after CPU_ONLINE, they can still be running in other CPUs before self rebinding. But the commit a9ab775 ("workqueue: directly restore CPU affinity of workers from CPU_ONLINE") makes rebind_workers() bind them all. So all workers are on the CPU before the CPU is down. And the comment in unbind_workers() refers to the workers "which are still executing works from before the last CPU down" is outdated. Just removed it. Signed-off-by: Lai Jiangshan <[email protected]> Signed-off-by: Tejun Heo <[email protected]>
1 parent 3e5f39e commit 11b45b0

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

kernel/workqueue.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4978,9 +4978,7 @@ static void unbind_workers(int cpu)
49784978
/*
49794979
* We've blocked all attach/detach operations. Make all workers
49804980
* unbound and set DISASSOCIATED. Before this, all workers
4981-
* except for the ones which are still executing works from
4982-
* before the last CPU down must be on the cpu. After
4983-
* this, they may become diasporas.
4981+
* must be on the cpu. After this, they may become diasporas.
49844982
*/
49854983
for_each_pool_worker(worker, pool)
49864984
worker->flags |= WORKER_UNBOUND;

0 commit comments

Comments
 (0)