Skip to content

Commit 177e15d

Browse files
Uwe Kleine-Königchanwoochoi
authored andcommitted
PM / devfreq: exynos-ppmu: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <[email protected]> Signed-off-by: Chanwoo Choi <[email protected]>
1 parent 45d8b57 commit 177e15d

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/devfreq/event/exynos-ppmu.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -692,18 +692,16 @@ static int exynos_ppmu_probe(struct platform_device *pdev)
692692
return 0;
693693
}
694694

695-
static int exynos_ppmu_remove(struct platform_device *pdev)
695+
static void exynos_ppmu_remove(struct platform_device *pdev)
696696
{
697697
struct exynos_ppmu *info = platform_get_drvdata(pdev);
698698

699699
clk_disable_unprepare(info->ppmu.clk);
700-
701-
return 0;
702700
}
703701

704702
static struct platform_driver exynos_ppmu_driver = {
705703
.probe = exynos_ppmu_probe,
706-
.remove = exynos_ppmu_remove,
704+
.remove_new = exynos_ppmu_remove,
707705
.driver = {
708706
.name = "exynos-ppmu",
709707
.of_match_table = exynos_ppmu_id_match,

0 commit comments

Comments
 (0)