Skip to content

Commit 1c0db6d

Browse files
committed
Merge tag 'drm-misc-next-fixes-2023-02-02' of git://anongit.freedesktop.org/drm/drm-misc into drm-next
Short summary of fixes pull: A number of simple fixes throughout the DRM codebase. Signed-off-by: Dave Airlie <[email protected]> From: Thomas Zimmermann <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/Y9twz2rqOP2+LjaT@linux-uq9g
2 parents 15a5744 + 84cc4c7 commit 1c0db6d

File tree

6 files changed

+12
-15
lines changed

6 files changed

+12
-15
lines changed

drivers/accel/Kconfig

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@
66
# as, but not limited to, Machine-Learning and Deep-Learning acceleration
77
# devices
88
#
9+
if DRM
10+
911
menuconfig DRM_ACCEL
1012
bool "Compute Acceleration Framework"
11-
depends on DRM
1213
help
1314
Framework for device drivers of compute acceleration devices, such
1415
as, but not limited to, Machine-Learning and Deep-Learning
@@ -25,3 +26,5 @@ menuconfig DRM_ACCEL
2526

2627
source "drivers/accel/habanalabs/Kconfig"
2728
source "drivers/accel/ivpu/Kconfig"
29+
30+
endif

drivers/accel/ivpu/ivpu_drv.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,6 @@ int ivpu_shutdown(struct ivpu_device *vdev)
356356

357357
static const struct file_operations ivpu_fops = {
358358
.owner = THIS_MODULE,
359-
.mmap = drm_gem_mmap,
360359
DRM_ACCEL_FOPS,
361360
};
362361

drivers/dma-buf/dma-fence.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ struct dma_fence *dma_fence_allocate_private_stub(void)
167167
0, 0);
168168

169169
set_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT,
170-
&dma_fence_stub.flags);
170+
&fence->flags);
171171

172172
dma_fence_signal(fence);
173173

drivers/gpu/drm/drm_gem_shmem_helper.c

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ void drm_gem_shmem_vunmap(struct drm_gem_shmem_object *shmem,
415415
}
416416
EXPORT_SYMBOL(drm_gem_shmem_vunmap);
417417

418-
static struct drm_gem_shmem_object *
418+
static int
419419
drm_gem_shmem_create_with_handle(struct drm_file *file_priv,
420420
struct drm_device *dev, size_t size,
421421
uint32_t *handle)
@@ -425,7 +425,7 @@ drm_gem_shmem_create_with_handle(struct drm_file *file_priv,
425425

426426
shmem = drm_gem_shmem_create(dev, size);
427427
if (IS_ERR(shmem))
428-
return shmem;
428+
return PTR_ERR(shmem);
429429

430430
/*
431431
* Allocate an id of idr table where the obj is registered
@@ -434,10 +434,8 @@ drm_gem_shmem_create_with_handle(struct drm_file *file_priv,
434434
ret = drm_gem_handle_create(file_priv, &shmem->base, handle);
435435
/* drop reference from allocate - handle holds it now. */
436436
drm_gem_object_put(&shmem->base);
437-
if (ret)
438-
return ERR_PTR(ret);
439437

440-
return shmem;
438+
return ret;
441439
}
442440

443441
/* Update madvise status, returns true if not purged, else
@@ -520,7 +518,6 @@ int drm_gem_shmem_dumb_create(struct drm_file *file, struct drm_device *dev,
520518
struct drm_mode_create_dumb *args)
521519
{
522520
u32 min_pitch = DIV_ROUND_UP(args->width * args->bpp, 8);
523-
struct drm_gem_shmem_object *shmem;
524521

525522
if (!args->pitch || !args->size) {
526523
args->pitch = min_pitch;
@@ -533,9 +530,7 @@ int drm_gem_shmem_dumb_create(struct drm_file *file, struct drm_device *dev,
533530
args->size = PAGE_ALIGN(args->pitch * args->height);
534531
}
535532

536-
shmem = drm_gem_shmem_create_with_handle(file, dev, args->size, &args->handle);
537-
538-
return PTR_ERR_OR_ZERO(shmem);
533+
return drm_gem_shmem_create_with_handle(file, dev, args->size, &args->handle);
539534
}
540535
EXPORT_SYMBOL_GPL(drm_gem_shmem_dumb_create);
541536

drivers/gpu/drm/tiny/simpledrm.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -719,8 +719,8 @@ static struct simpledrm_device *simpledrm_device_create(struct drm_driver *drv,
719719
drm_dbg(dev, "using system memory framebuffer at %pr\n", mem);
720720

721721
screen_base = devm_memremap(dev->dev, mem->start, resource_size(mem), MEMREMAP_WC);
722-
if (!screen_base)
723-
return ERR_PTR(-ENOMEM);
722+
if (IS_ERR(screen_base))
723+
return screen_base;
724724

725725
iosys_map_set_vaddr(&sdev->screen_base, screen_base);
726726
} else {

include/drm/drm_client.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ struct drm_client_dev {
108108
struct drm_mode_set *modesets;
109109

110110
/**
111-
* @hotplug failed:
111+
* @hotplug_failed:
112112
*
113113
* Set by client hotplug helpers if the hotplugging failed
114114
* before. It is usually not tried again.

0 commit comments

Comments
 (0)