Skip to content

Commit 1d60eab

Browse files
Dan CarpenterKalle Valo
authored andcommitted
wifi: mwl8k: initialize cmd->addr[] properly
This loop is supposed to copy the mac address to cmd->addr but the i++ increment is missing so it copies everything to cmd->addr[0] and only the last address is recorded. Fixes: 22bedad ("net: convert multicast list to list_head") Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: Kalle Valo <[email protected]> Link: https://msgid.link/[email protected]
1 parent 9875b54 commit 1d60eab

File tree

1 file changed

+1
-1
lines changed
  • drivers/net/wireless/marvell

1 file changed

+1
-1
lines changed

drivers/net/wireless/marvell/mwl8k.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2720,7 +2720,7 @@ __mwl8k_cmd_mac_multicast_adr(struct ieee80211_hw *hw, int allmulti,
27202720
cmd->action |= cpu_to_le16(MWL8K_ENABLE_RX_MULTICAST);
27212721
cmd->numaddr = cpu_to_le16(mc_count);
27222722
netdev_hw_addr_list_for_each(ha, mc_list) {
2723-
memcpy(cmd->addr[i], ha->addr, ETH_ALEN);
2723+
memcpy(cmd->addr[i++], ha->addr, ETH_ALEN);
27242724
}
27252725
}
27262726

0 commit comments

Comments
 (0)