Skip to content

Commit 37276e0

Browse files
Chao Haojoergroedel
authored andcommitted
iommu/mediatek: Add sub_comm id in translation fault
The max larb number that a iommu HW support is 8(larb0~larb7 in the below diagram). If the larb's number is over 8, we use a sub_common for merging several larbs into one larb. At this case, we will extend larb_id: bit[11:9] means common-id; bit[8:7] means subcommon-id; >From these two variables, we could get the real larb number when translation fault happen. The diagram is as below: EMI | IOMMU | ----------------- | | common1 common0 | | ----------------- | smi common | ------------------------------------ | | | | | | 3'd0 3'd1 3'd2 3'd3 ... 3'd7 <-common_id(max is 8) | | | | | | Larb0 Larb1 | Larb3 ... Larb7 | smi sub common | -------------------------- | | | | 2'd0 2'd1 2'd2 2'd3 <-sub_common_id(max is 4) | | | | Larb8 Larb9 Larb10 Larb11 In this patch we extend larb_remap[] to larb_remap[8][4] for this. larb_remap[x][y]: x means common-id above, y means subcommon_id above. We can also distinguish if the M4U HW has sub_common by HAS_SUB_COMM macro. Signed-off-by: Chao Hao <[email protected]> Reviewed-by: Yong Wu <[email protected]> Reviewed-by: Matthias Brugger <[email protected]> Cc: Matthias Brugger <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Joerg Roedel <[email protected]>
1 parent b053bc7 commit 37276e0

File tree

2 files changed

+18
-8
lines changed

2 files changed

+18
-8
lines changed

drivers/iommu/mtk_iommu.c

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,8 @@
9191
#define REG_MMU1_INVLD_PA 0x148
9292
#define REG_MMU0_INT_ID 0x150
9393
#define REG_MMU1_INT_ID 0x154
94+
#define F_MMU_INT_ID_COMM_ID(a) (((a) >> 9) & 0x7)
95+
#define F_MMU_INT_ID_SUB_COMM_ID(a) (((a) >> 7) & 0x3)
9496
#define F_MMU_INT_ID_LARB_ID(a) (((a) >> 7) & 0x7)
9597
#define F_MMU_INT_ID_PORT_ID(a) (((a) >> 2) & 0x1f)
9698

@@ -109,6 +111,7 @@
109111
#define HAS_VLD_PA_RNG BIT(2)
110112
#define RESET_AXI BIT(3)
111113
#define OUT_ORDER_WR_EN BIT(4)
114+
#define HAS_SUB_COMM BIT(5)
112115

113116
#define MTK_IOMMU_HAS_FLAG(pdata, _x) \
114117
((((pdata)->flags) & (_x)) == (_x))
@@ -239,7 +242,7 @@ static irqreturn_t mtk_iommu_isr(int irq, void *dev_id)
239242
struct mtk_iommu_data *data = dev_id;
240243
struct mtk_iommu_domain *dom = data->m4u_dom;
241244
u32 int_state, regval, fault_iova, fault_pa;
242-
unsigned int fault_larb, fault_port;
245+
unsigned int fault_larb, fault_port, sub_comm = 0;
243246
bool layer, write;
244247

245248
/* Read error info from registers */
@@ -255,10 +258,14 @@ static irqreturn_t mtk_iommu_isr(int irq, void *dev_id)
255258
}
256259
layer = fault_iova & F_MMU_FAULT_VA_LAYER_BIT;
257260
write = fault_iova & F_MMU_FAULT_VA_WRITE_BIT;
258-
fault_larb = F_MMU_INT_ID_LARB_ID(regval);
259261
fault_port = F_MMU_INT_ID_PORT_ID(regval);
260-
261-
fault_larb = data->plat_data->larbid_remap[fault_larb];
262+
if (MTK_IOMMU_HAS_FLAG(data->plat_data, HAS_SUB_COMM)) {
263+
fault_larb = F_MMU_INT_ID_COMM_ID(regval);
264+
sub_comm = F_MMU_INT_ID_SUB_COMM_ID(regval);
265+
} else {
266+
fault_larb = F_MMU_INT_ID_LARB_ID(regval);
267+
}
268+
fault_larb = data->plat_data->larbid_remap[fault_larb][sub_comm];
262269

263270
if (report_iommu_fault(&dom->domain, data->dev, fault_iova,
264271
write ? IOMMU_FAULT_WRITE : IOMMU_FAULT_READ)) {
@@ -785,21 +792,21 @@ static const struct mtk_iommu_plat_data mt2712_data = {
785792
.m4u_plat = M4U_MT2712,
786793
.flags = HAS_4GB_MODE | HAS_BCLK | HAS_VLD_PA_RNG,
787794
.inv_sel_reg = REG_MMU_INV_SEL_GEN1,
788-
.larbid_remap = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9},
795+
.larbid_remap = {{0}, {1}, {2}, {3}, {4}, {5}, {6}, {7}},
789796
};
790797

791798
static const struct mtk_iommu_plat_data mt8173_data = {
792799
.m4u_plat = M4U_MT8173,
793800
.flags = HAS_4GB_MODE | HAS_BCLK | RESET_AXI,
794801
.inv_sel_reg = REG_MMU_INV_SEL_GEN1,
795-
.larbid_remap = {0, 1, 2, 3, 4, 5}, /* Linear mapping. */
802+
.larbid_remap = {{0}, {1}, {2}, {3}, {4}, {5}}, /* Linear mapping. */
796803
};
797804

798805
static const struct mtk_iommu_plat_data mt8183_data = {
799806
.m4u_plat = M4U_MT8183,
800807
.flags = RESET_AXI,
801808
.inv_sel_reg = REG_MMU_INV_SEL_GEN1,
802-
.larbid_remap = {0, 4, 5, 6, 7, 2, 3, 1},
809+
.larbid_remap = {{0}, {4}, {5}, {6}, {7}, {2}, {3}, {1}},
803810
};
804811

805812
static const struct of_device_id mtk_iommu_of_ids[] = {

drivers/iommu/mtk_iommu.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@
1717
#include <linux/spinlock.h>
1818
#include <soc/mediatek/smi.h>
1919

20+
#define MTK_LARB_COM_MAX 8
21+
#define MTK_LARB_SUBCOM_MAX 4
22+
2023
struct mtk_iommu_suspend_reg {
2124
union {
2225
u32 standard_axi_mode;/* v1 */
@@ -41,7 +44,7 @@ struct mtk_iommu_plat_data {
4144
enum mtk_iommu_plat m4u_plat;
4245
u32 flags;
4346
u32 inv_sel_reg;
44-
unsigned char larbid_remap[MTK_LARB_NR_MAX];
47+
unsigned char larbid_remap[MTK_LARB_COM_MAX][MTK_LARB_SUBCOM_MAX];
4548
};
4649

4750
struct mtk_iommu_domain;

0 commit comments

Comments
 (0)