Skip to content

Commit 4d2587e

Browse files
mmindmmind
committed
arm64: dts: rockchip: fix rk3576 pcie unit addresses
The rk3576 pcie nodes currently use the apb register as their unit address which is the second reg area defined in the binding. As can be seen by the dtc warnings like ../arch/arm64/boot/dts/rockchip/rk3576.dtsi:1346.24-1398.5: Warning (simple_bus_reg): /soc/pcie@2a200000: simple-bus unit address format error, expected "22000000" ../arch/arm64/boot/dts/rockchip/rk3576.dtsi:1400.24-1452.5: Warning (simple_bus_reg): /soc/pcie@2a210000: simple-bus unit address format error, expected "22400000" using the first reg area as the unit address seems to be preferred. This is the dbi area per the binding, so adapt the unit address accordingly and move the nodes to their new position. Reported-by: kernel test robot <[email protected]> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ Signed-off-by: Heiko Stuebner <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 6e0f32d commit 4d2587e

File tree

1 file changed

+108
-108
lines changed

1 file changed

+108
-108
lines changed

‎arch/arm64/boot/dts/rockchip/rk3576.dtsi

Lines changed: 108 additions & 108 deletions
Original file line numberDiff line numberDiff line change
@@ -466,6 +466,114 @@
466466
#size-cells = <2>;
467467
ranges;
468468

469+
pcie0: pcie@22000000 {
470+
compatible = "rockchip,rk3576-pcie", "rockchip,rk3568-pcie";
471+
reg = <0x0 0x22000000 0x0 0x00400000>,
472+
<0x0 0x2a200000 0x0 0x00010000>,
473+
<0x0 0x20000000 0x0 0x00100000>;
474+
reg-names = "dbi", "apb", "config";
475+
bus-range = <0x0 0xf>;
476+
clocks = <&cru ACLK_PCIE0_MST>, <&cru ACLK_PCIE0_SLV>,
477+
<&cru ACLK_PCIE0_DBI>, <&cru PCLK_PCIE0>,
478+
<&cru CLK_PCIE0_AUX>;
479+
clock-names = "aclk_mst", "aclk_slv",
480+
"aclk_dbi", "pclk",
481+
"aux";
482+
device_type = "pci";
483+
interrupts = <GIC_SPI 281 IRQ_TYPE_LEVEL_HIGH>,
484+
<GIC_SPI 282 IRQ_TYPE_LEVEL_HIGH>,
485+
<GIC_SPI 279 IRQ_TYPE_LEVEL_HIGH>,
486+
<GIC_SPI 280 IRQ_TYPE_LEVEL_HIGH>,
487+
<GIC_SPI 278 IRQ_TYPE_LEVEL_HIGH>,
488+
<GIC_SPI 283 IRQ_TYPE_LEVEL_HIGH>;
489+
interrupt-names = "sys", "pmc", "msg", "legacy", "err", "msi";
490+
#interrupt-cells = <1>;
491+
interrupt-map-mask = <0 0 0 7>;
492+
interrupt-map = <0 0 0 1 &pcie0_intc 0>,
493+
<0 0 0 2 &pcie0_intc 1>,
494+
<0 0 0 3 &pcie0_intc 2>,
495+
<0 0 0 4 &pcie0_intc 3>;
496+
linux,pci-domain = <0>;
497+
max-link-speed = <2>;
498+
num-ib-windows = <8>;
499+
num-viewport = <8>;
500+
num-ob-windows = <2>;
501+
num-lanes = <1>;
502+
phys = <&combphy0_ps PHY_TYPE_PCIE>;
503+
phy-names = "pcie-phy";
504+
power-domains = <&power RK3576_PD_PHP>;
505+
ranges = <0x01000000 0x0 0x20100000 0x0 0x20100000 0x0 0x00100000
506+
0x02000000 0x0 0x20200000 0x0 0x20200000 0x0 0x00e00000
507+
0x03000000 0x9 0x00000000 0x9 0x00000000 0x0 0x80000000>;
508+
resets = <&cru SRST_PCIE0_POWER_UP>, <&cru SRST_P_PCIE0>;
509+
reset-names = "pwr", "pipe";
510+
#address-cells = <3>;
511+
#size-cells = <2>;
512+
status = "disabled";
513+
514+
pcie0_intc: legacy-interrupt-controller {
515+
interrupt-controller;
516+
#address-cells = <0>;
517+
#interrupt-cells = <1>;
518+
interrupt-parent = <&gic>;
519+
interrupts = <GIC_SPI 280 IRQ_TYPE_EDGE_RISING>;
520+
};
521+
};
522+
523+
pcie1: pcie@22400000 {
524+
compatible = "rockchip,rk3576-pcie", "rockchip,rk3568-pcie";
525+
reg = <0x0 0x22400000 0x0 0x00400000>,
526+
<0x0 0x2a210000 0x0 0x00010000>,
527+
<0x0 0x21000000 0x0 0x00100000>;
528+
reg-names = "dbi", "apb", "config";
529+
bus-range = <0x20 0x2f>;
530+
clocks = <&cru ACLK_PCIE1_MST>, <&cru ACLK_PCIE1_SLV>,
531+
<&cru ACLK_PCIE1_DBI>, <&cru PCLK_PCIE1>,
532+
<&cru CLK_PCIE1_AUX>;
533+
clock-names = "aclk_mst", "aclk_slv",
534+
"aclk_dbi", "pclk",
535+
"aux";
536+
device_type = "pci";
537+
interrupts = <GIC_SPI 267 IRQ_TYPE_LEVEL_HIGH>,
538+
<GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>,
539+
<GIC_SPI 265 IRQ_TYPE_LEVEL_HIGH>,
540+
<GIC_SPI 266 IRQ_TYPE_LEVEL_HIGH>,
541+
<GIC_SPI 264 IRQ_TYPE_LEVEL_HIGH>,
542+
<GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>;
543+
interrupt-names = "sys", "pmc", "msg", "legacy", "err", "msi";
544+
#interrupt-cells = <1>;
545+
interrupt-map-mask = <0 0 0 7>;
546+
interrupt-map = <0 0 0 1 &pcie1_intc 0>,
547+
<0 0 0 2 &pcie1_intc 1>,
548+
<0 0 0 3 &pcie1_intc 2>,
549+
<0 0 0 4 &pcie1_intc 3>;
550+
linux,pci-domain = <0>;
551+
max-link-speed = <2>;
552+
num-ib-windows = <8>;
553+
num-viewport = <8>;
554+
num-ob-windows = <2>;
555+
num-lanes = <1>;
556+
phys = <&combphy1_psu PHY_TYPE_PCIE>;
557+
phy-names = "pcie-phy";
558+
power-domains = <&power RK3576_PD_SUBPHP>;
559+
ranges = <0x01000000 0x0 0x21100000 0x0 0x21100000 0x0 0x00100000
560+
0x02000000 0x0 0x21200000 0x0 0x21200000 0x0 0x00e00000
561+
0x03000000 0x9 0x80000000 0x9 0x80000000 0x0 0x80000000>;
562+
resets = <&cru SRST_PCIE1_POWER_UP>, <&cru SRST_P_PCIE1>;
563+
reset-names = "pwr", "pipe";
564+
#address-cells = <3>;
565+
#size-cells = <2>;
566+
status = "disabled";
567+
568+
pcie1_intc: legacy-interrupt-controller {
569+
interrupt-controller;
570+
#address-cells = <0>;
571+
#interrupt-cells = <1>;
572+
interrupt-parent = <&gic>;
573+
interrupts = <GIC_SPI 266 IRQ_TYPE_EDGE_RISING>;
574+
};
575+
};
576+
469577
usb_drd0_dwc3: usb@23000000 {
470578
compatible = "rockchip,rk3576-dwc3", "snps,dwc3";
471579
reg = <0x0 0x23000000 0x0 0x400000>;
@@ -1343,114 +1451,6 @@
13431451
reg = <0x0 0x27f22100 0x0 0x20>;
13441452
};
13451453

1346-
pcie0: pcie@2a200000 {
1347-
compatible = "rockchip,rk3576-pcie", "rockchip,rk3568-pcie";
1348-
reg = <0x0 0x22000000 0x0 0x00400000>,
1349-
<0x0 0x2a200000 0x0 0x00010000>,
1350-
<0x0 0x20000000 0x0 0x00100000>;
1351-
reg-names = "dbi", "apb", "config";
1352-
bus-range = <0x0 0xf>;
1353-
clocks = <&cru ACLK_PCIE0_MST>, <&cru ACLK_PCIE0_SLV>,
1354-
<&cru ACLK_PCIE0_DBI>, <&cru PCLK_PCIE0>,
1355-
<&cru CLK_PCIE0_AUX>;
1356-
clock-names = "aclk_mst", "aclk_slv",
1357-
"aclk_dbi", "pclk",
1358-
"aux";
1359-
device_type = "pci";
1360-
interrupts = <GIC_SPI 281 IRQ_TYPE_LEVEL_HIGH>,
1361-
<GIC_SPI 282 IRQ_TYPE_LEVEL_HIGH>,
1362-
<GIC_SPI 279 IRQ_TYPE_LEVEL_HIGH>,
1363-
<GIC_SPI 280 IRQ_TYPE_LEVEL_HIGH>,
1364-
<GIC_SPI 278 IRQ_TYPE_LEVEL_HIGH>,
1365-
<GIC_SPI 283 IRQ_TYPE_LEVEL_HIGH>;
1366-
interrupt-names = "sys", "pmc", "msg", "legacy", "err", "msi";
1367-
#interrupt-cells = <1>;
1368-
interrupt-map-mask = <0 0 0 7>;
1369-
interrupt-map = <0 0 0 1 &pcie0_intc 0>,
1370-
<0 0 0 2 &pcie0_intc 1>,
1371-
<0 0 0 3 &pcie0_intc 2>,
1372-
<0 0 0 4 &pcie0_intc 3>;
1373-
linux,pci-domain = <0>;
1374-
max-link-speed = <2>;
1375-
num-ib-windows = <8>;
1376-
num-viewport = <8>;
1377-
num-ob-windows = <2>;
1378-
num-lanes = <1>;
1379-
phys = <&combphy0_ps PHY_TYPE_PCIE>;
1380-
phy-names = "pcie-phy";
1381-
power-domains = <&power RK3576_PD_PHP>;
1382-
ranges = <0x01000000 0x0 0x20100000 0x0 0x20100000 0x0 0x00100000
1383-
0x02000000 0x0 0x20200000 0x0 0x20200000 0x0 0x00e00000
1384-
0x03000000 0x9 0x00000000 0x9 0x00000000 0x0 0x80000000>;
1385-
resets = <&cru SRST_PCIE0_POWER_UP>, <&cru SRST_P_PCIE0>;
1386-
reset-names = "pwr", "pipe";
1387-
#address-cells = <3>;
1388-
#size-cells = <2>;
1389-
status = "disabled";
1390-
1391-
pcie0_intc: legacy-interrupt-controller {
1392-
interrupt-controller;
1393-
#address-cells = <0>;
1394-
#interrupt-cells = <1>;
1395-
interrupt-parent = <&gic>;
1396-
interrupts = <GIC_SPI 280 IRQ_TYPE_EDGE_RISING>;
1397-
};
1398-
};
1399-
1400-
pcie1: pcie@2a210000 {
1401-
compatible = "rockchip,rk3576-pcie", "rockchip,rk3568-pcie";
1402-
reg = <0x0 0x22400000 0x0 0x00400000>,
1403-
<0x0 0x2a210000 0x0 0x00010000>,
1404-
<0x0 0x21000000 0x0 0x00100000>;
1405-
reg-names = "dbi", "apb", "config";
1406-
bus-range = <0x20 0x2f>;
1407-
clocks = <&cru ACLK_PCIE1_MST>, <&cru ACLK_PCIE1_SLV>,
1408-
<&cru ACLK_PCIE1_DBI>, <&cru PCLK_PCIE1>,
1409-
<&cru CLK_PCIE1_AUX>;
1410-
clock-names = "aclk_mst", "aclk_slv",
1411-
"aclk_dbi", "pclk",
1412-
"aux";
1413-
device_type = "pci";
1414-
interrupts = <GIC_SPI 267 IRQ_TYPE_LEVEL_HIGH>,
1415-
<GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>,
1416-
<GIC_SPI 265 IRQ_TYPE_LEVEL_HIGH>,
1417-
<GIC_SPI 266 IRQ_TYPE_LEVEL_HIGH>,
1418-
<GIC_SPI 264 IRQ_TYPE_LEVEL_HIGH>,
1419-
<GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>;
1420-
interrupt-names = "sys", "pmc", "msg", "legacy", "err", "msi";
1421-
#interrupt-cells = <1>;
1422-
interrupt-map-mask = <0 0 0 7>;
1423-
interrupt-map = <0 0 0 1 &pcie1_intc 0>,
1424-
<0 0 0 2 &pcie1_intc 1>,
1425-
<0 0 0 3 &pcie1_intc 2>,
1426-
<0 0 0 4 &pcie1_intc 3>;
1427-
linux,pci-domain = <0>;
1428-
max-link-speed = <2>;
1429-
num-ib-windows = <8>;
1430-
num-viewport = <8>;
1431-
num-ob-windows = <2>;
1432-
num-lanes = <1>;
1433-
phys = <&combphy1_psu PHY_TYPE_PCIE>;
1434-
phy-names = "pcie-phy";
1435-
power-domains = <&power RK3576_PD_SUBPHP>;
1436-
ranges = <0x01000000 0x0 0x21100000 0x0 0x21100000 0x0 0x00100000
1437-
0x02000000 0x0 0x21200000 0x0 0x21200000 0x0 0x00e00000
1438-
0x03000000 0x9 0x80000000 0x9 0x80000000 0x0 0x80000000>;
1439-
resets = <&cru SRST_PCIE1_POWER_UP>, <&cru SRST_P_PCIE1>;
1440-
reset-names = "pwr", "pipe";
1441-
#address-cells = <3>;
1442-
#size-cells = <2>;
1443-
status = "disabled";
1444-
1445-
pcie1_intc: legacy-interrupt-controller {
1446-
interrupt-controller;
1447-
#address-cells = <0>;
1448-
#interrupt-cells = <1>;
1449-
interrupt-parent = <&gic>;
1450-
interrupts = <GIC_SPI 266 IRQ_TYPE_EDGE_RISING>;
1451-
};
1452-
};
1453-
14541454
gmac0: ethernet@2a220000 {
14551455
compatible = "rockchip,rk3576-gmac", "snps,dwmac-4.20a";
14561456
reg = <0x0 0x2a220000 0x0 0x10000>;

0 commit comments

Comments
 (0)