Skip to content

Commit 502cdd6

Browse files
AxelLinbroonie
authored andcommitted
regulator: mp5416: Fix output discharge enable bit for LDOs
The .active_discharge_on/.active_discharge_mask settings does not match the datasheet, fix it. Signed-off-by: Axel Lin <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent d69f763 commit 502cdd6

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

drivers/regulator/mp5416.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@
7373
.owner = THIS_MODULE, \
7474
}
7575

76-
#define MP5416LDO(_name, _id) \
76+
#define MP5416LDO(_name, _id, _dval) \
7777
[MP5416_LDO ## _id] = { \
7878
.id = MP5416_LDO ## _id, \
7979
.name = _name, \
@@ -87,9 +87,9 @@
8787
.vsel_mask = MP5416_MASK_VSET, \
8888
.enable_reg = MP5416_REG_LDO ##_id, \
8989
.enable_mask = MP5416_REGULATOR_EN, \
90-
.active_discharge_on = BIT(_id), \
90+
.active_discharge_on = _dval, \
9191
.active_discharge_reg = MP5416_REG_CTL2, \
92-
.active_discharge_mask = BIT(_id), \
92+
.active_discharge_mask = _dval, \
9393
.owner = THIS_MODULE, \
9494
}
9595

@@ -155,10 +155,10 @@ static struct regulator_desc mp5416_regulators_desc[MP5416_MAX_REGULATORS] = {
155155
MP5416BUCK("buck2", 2, mp5416_I_limits2, MP5416_REG_CTL1, BIT(1), 2),
156156
MP5416BUCK("buck3", 3, mp5416_I_limits1, MP5416_REG_CTL1, BIT(2), 1),
157157
MP5416BUCK("buck4", 4, mp5416_I_limits2, MP5416_REG_CTL2, BIT(5), 2),
158-
MP5416LDO("ldo1", 1),
159-
MP5416LDO("ldo2", 2),
160-
MP5416LDO("ldo3", 3),
161-
MP5416LDO("ldo4", 4),
158+
MP5416LDO("ldo1", 1, BIT(4)),
159+
MP5416LDO("ldo2", 2, BIT(3)),
160+
MP5416LDO("ldo3", 3, BIT(2)),
161+
MP5416LDO("ldo4", 4, BIT(1)),
162162
};
163163

164164
/*

0 commit comments

Comments
 (0)