Skip to content

Commit d69f763

Browse files
GustavoARSilvabroonie
authored andcommitted
regulator: da9062: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertenly introduced[3] to the codebase from now on. This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] KSPP#21 [3] commit 7649773 ("cxgb3/l2t: Fix undefined behaviour") Signed-off-by: Gustavo A. R. Silva <[email protected]> Acked-by: Adam Thomson <[email protected]> Link: https://lore.kernel.org/r/20200211234612.GA28682@embeddedor Signed-off-by: Mark Brown <[email protected]>
1 parent 23a653e commit d69f763

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/regulator/da9062-regulator.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ struct da9062_regulators {
7373
int irq_ldo_lim;
7474
unsigned n_regulators;
7575
/* Array size to be defined during init. Keep at end. */
76-
struct da9062_regulator regulator[0];
76+
struct da9062_regulator regulator[];
7777
};
7878

7979
/* Regulator operations */

0 commit comments

Comments
 (0)