Skip to content

Commit 5a50b8b

Browse files
Naveenaidubjorn-helgaas
authored andcommitted
PCI: aardvark: Drop error data fabrication when config read fails
If config pci_ops.read() methods return failure, the PCI_OP_READ() and PCI_USER_READ_CONFIG() wrappers use PCI_SET_ERROR_RESPONSE() to set the data value, so there's no need to set it in the pci_ops.read() methods themselves. Drop the unnecessary data value fabrication when pci_ops.read() fails. Link: https://lore.kernel.org/r/335014f2b44cdf24ed1e37cb7c88f6c5de896cc2.1637243717.git.naveennaidu479@gmail.com Signed-off-by: Naveen Naidu <[email protected]> Signed-off-by: Bjorn Helgaas <[email protected]> Reviewed-by: Pali Rohár <[email protected]>
1 parent 7dcd026 commit 5a50b8b

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/pci/controller/pci-aardvark.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1026,10 +1026,8 @@ static int advk_pcie_rd_conf(struct pci_bus *bus, u32 devfn,
10261026
u32 reg;
10271027
int ret;
10281028

1029-
if (!advk_pcie_valid_device(pcie, bus, devfn)) {
1030-
*val = 0xffffffff;
1029+
if (!advk_pcie_valid_device(pcie, bus, devfn))
10311030
return PCIBIOS_DEVICE_NOT_FOUND;
1032-
}
10331031

10341032
if (pci_is_root_bus(bus))
10351033
return pci_bridge_emul_conf_read(&pcie->bridge, where,

0 commit comments

Comments
 (0)