Skip to content

Commit 7dcd026

Browse files
Naveenaidubjorn-helgaas
authored andcommitted
PCI: kirin: Drop error data fabrication when config read fails
If config pci_ops.read() methods return failure, the PCI_OP_READ() and PCI_USER_READ_CONFIG() wrappers use PCI_SET_ERROR_RESPONSE() to set the data value, so there's no need to set it in the pci_ops.read() methods themselves. Drop the unnecessary data value fabrication when pci_ops.read() fails. Link: https://lore.kernel.org/r/f87e22bc09a471d2cf15ad05dfd6432f57739aed.1637243717.git.naveennaidu479@gmail.com Signed-off-by: Naveen Naidu <[email protected]> Signed-off-by: Bjorn Helgaas <[email protected]>
1 parent f4a44c1 commit 7dcd026

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/pci/controller/dwc/pcie-kirin.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -530,10 +530,8 @@ static int kirin_pcie_rd_own_conf(struct pci_bus *bus, unsigned int devfn,
530530
{
531531
struct dw_pcie *pci = to_dw_pcie_from_pp(bus->sysdata);
532532

533-
if (PCI_SLOT(devfn)) {
534-
*val = ~0;
533+
if (PCI_SLOT(devfn))
535534
return PCIBIOS_DEVICE_NOT_FOUND;
536-
}
537535

538536
*val = dw_pcie_read_dbi(pci, where, size);
539537
return PCIBIOS_SUCCESSFUL;

0 commit comments

Comments
 (0)