Skip to content

Commit f4a44c1

Browse files
Naveenaidubjorn-helgaas
authored andcommitted
PCI: histb: Drop error data fabrication when config read fails
If config pci_ops.read() methods return failure, the PCI_OP_READ() and PCI_USER_READ_CONFIG() wrappers use PCI_SET_ERROR_RESPONSE() to set the data value, so there's no need to set it in the pci_ops.read() methods themselves. Drop the unnecessary data value fabrication when pci_ops.read() fails. Link: https://lore.kernel.org/r/7da7ea760abc5f85cad6e9b0d3e59eebd93f50d3.1637243717.git.naveennaidu479@gmail.com Signed-off-by: Naveen Naidu <[email protected]> Signed-off-by: Bjorn Helgaas <[email protected]>
1 parent 8ed2196 commit f4a44c1

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/pci/controller/dwc/pcie-histb.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -127,10 +127,8 @@ static int histb_pcie_rd_own_conf(struct pci_bus *bus, unsigned int devfn,
127127
{
128128
struct dw_pcie *pci = to_dw_pcie_from_pp(bus->sysdata);
129129

130-
if (PCI_SLOT(devfn)) {
131-
*val = ~0;
130+
if (PCI_SLOT(devfn))
132131
return PCIBIOS_DEVICE_NOT_FOUND;
133-
}
134132

135133
*val = dw_pcie_read_dbi(pci, where, size);
136134
return PCIBIOS_SUCCESSFUL;

0 commit comments

Comments
 (0)