Skip to content

Commit 8ed2196

Browse files
Naveenaidubjorn-helgaas
authored andcommitted
PCI: exynos: Drop error data fabrication when config read fails
If config pci_ops.read() methods return failure, the PCI_OP_READ() and PCI_USER_READ_CONFIG() wrappers use PCI_SET_ERROR_RESPONSE() to set the data value, so there's no need to set it in the pci_ops.read() methods themselves. Drop the unnecessary data value fabrication when pci_ops.read() fails. Link: https://lore.kernel.org/r/765c2f27d85fcee4eb137023dc0a8f864eee9e36.1637243717.git.naveennaidu479@gmail.com Signed-off-by: Naveen Naidu <[email protected]> Signed-off-by: Bjorn Helgaas <[email protected]>
1 parent 7e97685 commit 8ed2196

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/pci/controller/dwc/pci-exynos.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -216,10 +216,8 @@ static int exynos_pcie_rd_own_conf(struct pci_bus *bus, unsigned int devfn,
216216
{
217217
struct dw_pcie *pci = to_dw_pcie_from_pp(bus->sysdata);
218218

219-
if (PCI_SLOT(devfn)) {
220-
*val = ~0;
219+
if (PCI_SLOT(devfn))
221220
return PCIBIOS_DEVICE_NOT_FOUND;
222-
}
223221

224222
*val = dw_pcie_read_dbi(pci, where, size);
225223
return PCIBIOS_SUCCESSFUL;

0 commit comments

Comments
 (0)