Skip to content

Commit 5fc586a

Browse files
author
Thomas Zimmermann
committed
drm/fb-helper: Perform damage handling in deferred-I/O helper
Call fb_dirty directly from drm_fb_helper_deferred_io() to avoid the latency of running the damage worker. The deferred-I/O helper drm_fb_helper_deferred_io() runs in a worker thread at regular intervals as part of writing to mmaped framebuffer memory. It used to schedule the fbdev damage worker to flush the framebuffer. Changing this to flushing the framebuffer directly avoids the latency introduced by the damage worker. v2: * remove fb_dirty from defio in separate patch (Daniel) Signed-off-by: Thomas Zimmermann <[email protected]> Reviewed-by: Daniel Vetter <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 9b72324 commit 5fc586a

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

drivers/gpu/drm/drm_fb_helper.c

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -666,10 +666,16 @@ void drm_fb_helper_deferred_io(struct fb_info *info, struct list_head *pagerefli
666666

667667
if (min_off < max_off) {
668668
drm_fb_helper_memory_range_to_clip(info, min_off, max_off - min_off, &damage_area);
669-
drm_fb_helper_damage(helper, damage_area.x1, damage_area.y1,
670-
drm_rect_width(&damage_area),
671-
drm_rect_height(&damage_area));
669+
drm_fb_helper_add_damage_clip(helper, damage_area.x1, damage_area.y1,
670+
drm_rect_width(&damage_area),
671+
drm_rect_height(&damage_area));
672672
}
673+
674+
/*
675+
* Flushes all dirty pages from mmap's pageref list and the
676+
* areas that have been written by struct fb_ops callbacks.
677+
*/
678+
drm_fb_helper_fb_dirty(helper);
673679
}
674680
EXPORT_SYMBOL(drm_fb_helper_deferred_io);
675681

0 commit comments

Comments
 (0)