Skip to content

Commit 65d4638

Browse files
committed
drm/atomic-helper: Change parameter name of drm_atomic_helper_modeset_disables()
drm_atomic_helper_modeset_disables() disables all the outputs affected by a commit. It takes the drm_atomic_state being committed as a parameter. However, that parameter name is called (and documented) as old_state, which is pretty confusing. Let's rename that variable as state. Reviewed-by: Dmitry Baryshkov <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Maxime Ripard <[email protected]>
1 parent af2ea3d commit 65d4638

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

drivers/gpu/drm/drm_atomic_helper.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1439,7 +1439,7 @@ crtc_set_mode(struct drm_device *dev, struct drm_atomic_state *old_state)
14391439
/**
14401440
* drm_atomic_helper_commit_modeset_disables - modeset commit to disable outputs
14411441
* @dev: DRM device
1442-
* @old_state: atomic state object with old state structures
1442+
* @state: atomic state object being committed
14431443
*
14441444
* This function shuts down all the outputs that need to be shut down and
14451445
* prepares them (if required) with the new mode.
@@ -1451,14 +1451,14 @@ crtc_set_mode(struct drm_device *dev, struct drm_atomic_state *old_state)
14511451
* PM since planes updates then only happen when the CRTC is actually enabled.
14521452
*/
14531453
void drm_atomic_helper_commit_modeset_disables(struct drm_device *dev,
1454-
struct drm_atomic_state *old_state)
1454+
struct drm_atomic_state *state)
14551455
{
1456-
disable_outputs(dev, old_state);
1456+
disable_outputs(dev, state);
14571457

1458-
drm_atomic_helper_update_legacy_modeset_state(dev, old_state);
1459-
drm_atomic_helper_calc_timestamping_constants(old_state);
1458+
drm_atomic_helper_update_legacy_modeset_state(dev, state);
1459+
drm_atomic_helper_calc_timestamping_constants(state);
14601460

1461-
crtc_set_mode(dev, old_state);
1461+
crtc_set_mode(dev, state);
14621462
}
14631463
EXPORT_SYMBOL(drm_atomic_helper_commit_modeset_disables);
14641464

0 commit comments

Comments
 (0)