Skip to content

Commit af2ea3d

Browse files
committed
drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_tail_rpm()
drm_atomic_helper_commit_tail_rpm() is the final part of an atomic commit, and is given the state being committed as a parameter. However, that parameter is named old_state, but documented as the "new modeset state" which is all super confusing. Let's rename that parameter to state. Reviewed-by: Dmitry Baryshkov <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Maxime Ripard <[email protected]>
1 parent 63379db commit af2ea3d

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

drivers/gpu/drm/drm_atomic_helper.c

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1801,32 +1801,32 @@ EXPORT_SYMBOL(drm_atomic_helper_commit_tail);
18011801

18021802
/**
18031803
* drm_atomic_helper_commit_tail_rpm - commit atomic update to hardware
1804-
* @old_state: new modeset state to be committed
1804+
* @state: new modeset state to be committed
18051805
*
18061806
* This is an alternative implementation for the
18071807
* &drm_mode_config_helper_funcs.atomic_commit_tail hook, for drivers
18081808
* that support runtime_pm or need the CRTC to be enabled to perform a
18091809
* commit. Otherwise, one should use the default implementation
18101810
* drm_atomic_helper_commit_tail().
18111811
*/
1812-
void drm_atomic_helper_commit_tail_rpm(struct drm_atomic_state *old_state)
1812+
void drm_atomic_helper_commit_tail_rpm(struct drm_atomic_state *state)
18131813
{
1814-
struct drm_device *dev = old_state->dev;
1814+
struct drm_device *dev = state->dev;
18151815

1816-
drm_atomic_helper_commit_modeset_disables(dev, old_state);
1816+
drm_atomic_helper_commit_modeset_disables(dev, state);
18171817

1818-
drm_atomic_helper_commit_modeset_enables(dev, old_state);
1818+
drm_atomic_helper_commit_modeset_enables(dev, state);
18191819

1820-
drm_atomic_helper_commit_planes(dev, old_state,
1820+
drm_atomic_helper_commit_planes(dev, state,
18211821
DRM_PLANE_COMMIT_ACTIVE_ONLY);
18221822

1823-
drm_atomic_helper_fake_vblank(old_state);
1823+
drm_atomic_helper_fake_vblank(state);
18241824

1825-
drm_atomic_helper_commit_hw_done(old_state);
1825+
drm_atomic_helper_commit_hw_done(state);
18261826

1827-
drm_atomic_helper_wait_for_vblanks(dev, old_state);
1827+
drm_atomic_helper_wait_for_vblanks(dev, state);
18281828

1829-
drm_atomic_helper_cleanup_planes(dev, old_state);
1829+
drm_atomic_helper_cleanup_planes(dev, state);
18301830
}
18311831
EXPORT_SYMBOL(drm_atomic_helper_commit_tail_rpm);
18321832

0 commit comments

Comments
 (0)