Skip to content

Commit 65fbec3

Browse files
committed
spi: Fix pm_runtime_set_suspended() with runtime pm
Merge series from Jinjie Ruan <[email protected]>: Fix pm_runtime_set_suspended() with runtime pm enabled, and fix the missing check for spi-cadence. Jinjie Ruan (3): spi: spi-imx: Fix pm_runtime_set_suspended() with runtime pm enabled spi: spi-cadence: Fix pm_runtime_set_suspended() with runtime pm enabled spi: spi-cadence: Fix missing spi_controller_is_target() check drivers/spi/spi-cadence.c | 8 +++++--- drivers/spi/spi-imx.c | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) -- 2.34.1
2 parents 68a1670 + 3eae4a9 commit 65fbec3

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

drivers/spi/spi-cadence.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -678,8 +678,8 @@ static int cdns_spi_probe(struct platform_device *pdev)
678678

679679
clk_dis_all:
680680
if (!spi_controller_is_target(ctlr)) {
681-
pm_runtime_set_suspended(&pdev->dev);
682681
pm_runtime_disable(&pdev->dev);
682+
pm_runtime_set_suspended(&pdev->dev);
683683
}
684684
remove_ctlr:
685685
spi_controller_put(ctlr);
@@ -701,8 +701,10 @@ static void cdns_spi_remove(struct platform_device *pdev)
701701

702702
cdns_spi_write(xspi, CDNS_SPI_ER, CDNS_SPI_ER_DISABLE);
703703

704-
pm_runtime_set_suspended(&pdev->dev);
705-
pm_runtime_disable(&pdev->dev);
704+
if (!spi_controller_is_target(ctlr)) {
705+
pm_runtime_disable(&pdev->dev);
706+
pm_runtime_set_suspended(&pdev->dev);
707+
}
706708

707709
spi_unregister_controller(ctlr);
708710
}

drivers/spi/spi-imx.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1865,8 +1865,8 @@ static int spi_imx_probe(struct platform_device *pdev)
18651865
spi_imx_sdma_exit(spi_imx);
18661866
out_runtime_pm_put:
18671867
pm_runtime_dont_use_autosuspend(spi_imx->dev);
1868-
pm_runtime_set_suspended(&pdev->dev);
18691868
pm_runtime_disable(spi_imx->dev);
1869+
pm_runtime_set_suspended(&pdev->dev);
18701870

18711871
clk_disable_unprepare(spi_imx->clk_ipg);
18721872
out_put_per:

0 commit comments

Comments
 (0)