Skip to content

Commit 66be340

Browse files
Pavel Machekrobclark
authored andcommitted
drm/msm: fix leaks if initialization fails
We should free resources in unlikely case of allocation failure. Signed-off-by: Pavel Machek <[email protected]> Signed-off-by: Rob Clark <[email protected]>
1 parent c479017 commit 66be340

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

drivers/gpu/drm/msm/msm_drv.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -444,8 +444,10 @@ static int msm_drm_init(struct device *dev, struct drm_driver *drv)
444444
if (!dev->dma_parms) {
445445
dev->dma_parms = devm_kzalloc(dev, sizeof(*dev->dma_parms),
446446
GFP_KERNEL);
447-
if (!dev->dma_parms)
448-
return -ENOMEM;
447+
if (!dev->dma_parms) {
448+
ret = -ENOMEM;
449+
goto err_msm_uninit;
450+
}
449451
}
450452
dma_set_max_seg_size(dev, DMA_BIT_MASK(32));
451453

0 commit comments

Comments
 (0)