Skip to content

Commit 66f3cb7

Browse files
AlisonSchofielddjbw
authored andcommitted
tools/testing/cxl: Remove cxl_test module math loading message
Commit "tools/testing/cxl: Add XOR Math support to cxl_test" added a module parameter to cxl_test for the interleave_arithmetic option. In doing so, it also added this dev_dbg() message describing which option cxl_test used during load: "[ 111.743246] (NULL device *): cxl_test loading modulo math option" That "(NULL device *)" has raised needless user concern. Remove the dev_dbg() message and make the module_param readable via sysfs for users that need to know which math option is active. Suggested-by: Dan Williams <[email protected]> Reviewed-by: Vishal Verma <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alison Schofield <[email protected]> Signed-off-by: Dan Williams <[email protected]>
1 parent ee611e5 commit 66f3cb7

File tree

1 file changed

+1
-3
lines changed
  • tools/testing/cxl/test

1 file changed

+1
-3
lines changed

tools/testing/cxl/test/cxl.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1143,11 +1143,9 @@ static __init int cxl_test_init(void)
11431143
if (interleave_arithmetic == 1) {
11441144
cfmws_start = CFMWS_XOR_ARRAY_START;
11451145
cfmws_end = CFMWS_XOR_ARRAY_END;
1146-
dev_dbg(NULL, "cxl_test loading xor math option\n");
11471146
} else {
11481147
cfmws_start = CFMWS_MOD_ARRAY_START;
11491148
cfmws_end = CFMWS_MOD_ARRAY_END;
1150-
dev_dbg(NULL, "cxl_test loading modulo math option\n");
11511149
}
11521150

11531151
rc = populate_cedt();
@@ -1334,7 +1332,7 @@ static __exit void cxl_test_exit(void)
13341332
unregister_cxl_mock_ops(&cxl_mock_ops);
13351333
}
13361334

1337-
module_param(interleave_arithmetic, int, 0000);
1335+
module_param(interleave_arithmetic, int, 0444);
13381336
MODULE_PARM_DESC(interleave_arithmetic, "Modulo:0, XOR:1");
13391337
module_init(cxl_test_init);
13401338
module_exit(cxl_test_exit);

0 commit comments

Comments
 (0)