Skip to content

Commit 69a9dcb

Browse files
ubizjakdlezcano
authored andcommitted
clocksource/drivers/jcore: Use request_percpu_irq()
Use request_percpu_irq() instead of request_irq() to solve the following sparse warning: jcore-pit.c:173:40: warning: incorrect type in argument 5 (different address spaces) jcore-pit.c:173:40: expected void *dev jcore-pit.c:173:40: got struct jcore_pit [noderef] __percpu *static [assigned] [toplevel] jcore_pit_percpu Compile tested only. Signed-off-by: Uros Bizjak <[email protected]> Cc: Daniel Lezcano <[email protected]> Cc: Thomas Gleixner <[email protected]> Cc: Rich Felker <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Daniel Lezcano <[email protected]>
1 parent 2e02da1 commit 69a9dcb

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

drivers/clocksource/jcore-pit.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ static int jcore_pit_local_init(unsigned cpu)
120120

121121
static irqreturn_t jcore_timer_interrupt(int irq, void *dev_id)
122122
{
123-
struct jcore_pit *pit = this_cpu_ptr(dev_id);
123+
struct jcore_pit *pit = dev_id;
124124

125125
if (clockevent_state_oneshot(&pit->ced))
126126
jcore_pit_disable(pit);
@@ -168,9 +168,8 @@ static int __init jcore_pit_init(struct device_node *node)
168168
return -ENOMEM;
169169
}
170170

171-
err = request_irq(pit_irq, jcore_timer_interrupt,
172-
IRQF_TIMER | IRQF_PERCPU,
173-
"jcore_pit", jcore_pit_percpu);
171+
err = request_percpu_irq(pit_irq, jcore_timer_interrupt,
172+
"jcore_pit", jcore_pit_percpu);
174173
if (err) {
175174
pr_err("pit irq request failed: %d\n", err);
176175
free_percpu(jcore_pit_percpu);

0 commit comments

Comments
 (0)