Skip to content

Commit 6f88f12

Browse files
Asbjørn Sloth Tønnesenkuba-moo
authored andcommitted
net: qede: use extack in qede_set_v6_tuple_to_profile()
Convert qede_set_v6_tuple_to_profile() to take extack, and drop the edev argument. Convert DP_INFO call to use NL_SET_ERR_MSG_MOD instead. In calls to qede_set_v6_tuple_to_profile(), use NULL as extack for now, until a subsequent patch makes extack available. Only compile tested. Signed-off-by: Asbjørn Sloth Tønnesen <[email protected]> Reviewed-by: Simon Horman <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent a7c9540 commit 6f88f12

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

drivers/net/ethernet/qlogic/qede/qede_filter.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1549,9 +1549,9 @@ static int qede_set_v4_tuple_to_profile(struct qede_dev *edev,
15491549
return 0;
15501550
}
15511551

1552-
static int qede_set_v6_tuple_to_profile(struct qede_dev *edev,
1553-
struct qede_arfs_tuple *t,
1554-
struct in6_addr *zaddr)
1552+
static int qede_set_v6_tuple_to_profile(struct qede_arfs_tuple *t,
1553+
struct in6_addr *zaddr,
1554+
struct netlink_ext_ack *extack)
15551555
{
15561556
/* We must have Only 4-tuples/l4 port/src ip/dst ip
15571557
* as an input.
@@ -1573,7 +1573,7 @@ static int qede_set_v6_tuple_to_profile(struct qede_dev *edev,
15731573
!memcmp(&t->src_ipv6, zaddr, sizeof(struct in6_addr))) {
15741574
t->mode = QED_FILTER_CONFIG_MODE_IP_DEST;
15751575
} else {
1576-
DP_INFO(edev, "Invalid N-tuple\n");
1576+
NL_SET_ERR_MSG_MOD(extack, "Invalid N-tuple");
15771577
return -EOPNOTSUPP;
15781578
}
15791579

@@ -1752,7 +1752,7 @@ qede_flow_parse_v6_common(struct qede_dev *edev, struct flow_rule *rule,
17521752
if (err)
17531753
return err;
17541754

1755-
return qede_set_v6_tuple_to_profile(edev, t, &zero_addr);
1755+
return qede_set_v6_tuple_to_profile(t, &zero_addr, NULL);
17561756
}
17571757

17581758
static int

0 commit comments

Comments
 (0)